Skip to content
OverviewSolutions
6
Comments
9
Moustafa Mahmoud
@DevMoustafa97

All comments

  • Sami ur Rahman•370
    @qsrahmanSubmitted about 4 years ago

    IP-API only allows free use of http api, so visiting the live site while using https will refuse the content from the api to be served. The easiest solution would be to host the app where https is not enforced. If anyone can give advice, it would be helpful to learn some alternate solutions/good practices.

    Responsive page using CSS, Fetch API , LeafletJS and IP-API

    2
    Moustafa Mahmoud•245
    @DevMoustafa97Posted about 4 years ago

    Good job for the ui but it doesn't work with me I put my IP press enter and nothing change where did you get this challenge I can't find it in the challenges page

    0
  • Moustafa Mahmoud•245
    @DevMoustafa97Posted over 4 years ago

    Really good just set the outline to none in the button

    0
  • Moustafa Mahmoud•245
    @DevMoustafa97Posted over 4 years ago

    Good job Maha, Just three points if you don't mind -you should add some padding-bottom to the right lower square -make font inside the button more bold and a little bigger -the entire box should have box-shadow Otherwise it is a good implementation

    0
  • Moustafa Mahmoud•245
    @DevMoustafa97Posted over 4 years ago

    Really good !

    0
  • Moustafa Mahmoud•245
    @DevMoustafa97Posted over 4 years ago

    Perfect! just three points

    • make logo smaller a little bit
    • more margin between boxes
    • reduce the border radius of the white box

    otherwise it is perfect

    1
  • Moustafa Mahmoud•245
    @DevMoustafa97Posted over 4 years ago

    Why my solution always taller than the design ?!!!

    0
  • Moustafa Mahmoud•245
    @DevMoustafa97Posted over 4 years ago

    great work but just 2 points you should disable the outline of the form's fields because it is not mentioned in the design terms and services should be a died link not just a text but still good job

    0
  • Alexander Heo•80
    @AlexanderHeoSubmitted over 4 years ago

    I'm finding it difficult to get pixel perfect, even with an overlay tool like PerfectPixel. Any suggestions on how to get the font size, letter-spacing, and line heights more accurate?

    HTML & CSS, media queries and keyframes

    4
    Moustafa Mahmoud•245
    @DevMoustafa97Posted over 4 years ago

    perfect !!

    0
  • Mindaugas Jocevicius•70
    @MindaugasJ88Submitted over 4 years ago

    Hi, I just finished my first HTML and CSS project, therefore I have some questions:

    1. Does my website meets the responsive website standards? As I was trying to reduce the size of screen, the columns wraps and turns into the mobile version. Do you see any places where it's working/looking wrong?
    2. When it's best to use percent values and when fixed pixels values? At first I thought that I need to use everywhere percent values in order to make everything responsive, but I saw that it's difficult when you using percentage both to parent and child items. So I used both pixels and percentage, just wondering what is the best practice?
    3. Can you check the classes code? Now I had literraly styled everything in styles.css files. First I had styled tag selectors and then created bunch of class selectors classes. What could be improved in terms of styling logic and naming? Was my approach effective?

    I'm grateful for any feeback. Thank you! ps: code is in two files - index.html and css/styles.css

    HTML and CSS site using Flexbox

    3
    Moustafa Mahmoud•245
    @DevMoustafa97Posted over 4 years ago

    good work but if you don't mind your solution as small issues

    • price $29 should be bold using css or just b tag
    • you should resize your signup button and take care of padding and font size inside it

    but still great work

    1