Enziu
@DefinitelyNotPatrickAll comments
- P@163rohanreddySubmitted 4 days ago
- @adeyshSubmitted about 1 month agoWhat are you most proud of, and what would you do differently next time?
I created the layout pretty close to the design png and was able to figure out the grid card layout by tinkering with
What challenges did you encounter, and how did you overcome them?grid-template-areas
property. So I would try to be more organized next time with the code as it gets messy real quick.- The main challenge was to figure out the card layout which I had to search for on google. After you figure it out you realize that It was not that hard actually.
- I also encountered problems in making the layout reponsive according to the container that my main layout was in.
- I think the html markup is pretty accurate but the styles that I have used may be overly complicated according to the bem syntax that I have used.
- If you see some code that is unnecessary complex, please give me your feedback as to why you thought about doing that and I will surely reflect upon that. Thnx.
P@DefinitelyNotPatrickPosted about 1 month agoI can't see how it works because I don't have access to the site. Could you change it?
1 - @adeyshSubmitted about 2 months agoWhat are you most proud of, and what would you do differently next time?
- I built this using SCSS for the first time which took some hard learning.
- using SCSS syntax , more like knowing where I can write code using it because in the long run it would be very helpful to write optimized code, so for this challenge I tried following a workflow.
How do you guys organize your scss files? The workflow and directory structure that I followed was from coder coder.
P@DefinitelyNotPatrickPosted about 1 month agoOne-to-one style, good job and long may it continue. I saw that when hovering over the button with the cursor it does not change to pointer
0 - @mts-mlSubmitted 8 months agoWhat challenges did you encounter, and how did you overcome them?
This project had a lot of tags, so to facilitate CSS development, I wanted to use nesting. Since styled components and SCSS modules don't work in pure HTML/CSS projects, I did some research and found out that you can use Sass with HTML. You just need to configure the package.json file and run yarn watch-css in the terminal.
It helped a lot.
What specific areas of your project would you like help with?Would like some tips and constructive criticism.
P@DefinitelyNotPatrickPosted 8 months agoIt's cool that you're using scss and that the code is semantic but it would be better if you referenced classes rather than tags directly and it's cool that you put alt in the IMG tag
0 - @ab-0dSubmitted 8 months agoP@DefinitelyNotPatrickPosted 8 months ago
The design has been reproduced one-to-one gait card is smaller and the photo has been changed. Everything is in its place anyway
0 - P@NegligenceSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
- Mixins for Media Queries
I'm very happy to be able to use my mixins
What challenges did you encounter, and how did you overcome them?@include mobile-media-query(1440px)
and@include desktop-media-query(374px)
. From now on this is how I'm going to create my media queries.- Image Wrapper
I learned the benefit of wrapping a container on my img
In this particular design, it was needed because resizing the image itself did not reflect the design. I needed to set a smaller container size, added
overflow:hidden;
to hide the extra contents, and also add display grid to be able to setjustify-content: center;
to the cropped image..blog-image { width: 100%; height: rem(200px); border-radius: rem(10px); justify-self: center; justify-content: center; overflow: hidden; }
P@DefinitelyNotPatrickPosted 8 months agoThe site is responsive and the design is as it was intended. Great job!!!
1 - @ab-0dSubmitted 8 months agoP@DefinitelyNotPatrickPosted 8 months ago
The design is reproduced perfectly. And it displays well on screens, however, the description of the picture is missing and people with a screen reader will not even know what kind of picture it is.
0