@Flaviane-BrumSubmitted almost 3 years ago
Please provide feedback, so I can do better in the future, thank you.
David Emad
@DavidEmad01All comments
- @renrasSubmitted almost 3 years ago
I actually made this as part of an assessment from an employer. Also my first time using sass and vanilla js on a project. Let me know what you guys think.
@DavidEmad01Posted almost 3 years agoNice Work Dear
=> You can use:
- transition-duration for the buttons
- hover for links
- hover for social links
Continue Coding ✌✌
Marked as helpful1 - @tbscanlonSubmitted almost 3 years ago
My HTML and CSS fundamentals are a bit rusty, so any feedback focused there would be much appreciated!
@DavidEmad01Posted almost 3 years agoGood Work
- You can use some margin-top for the main box
Keep Going ✌
0 - @Olu-martinsSubmitted almost 3 years ago
Please what do I need to improve on?
@DavidEmad01Posted almost 3 years agoNice Work
- You can remove type="button" from the button for html report
Keep Going ✌✌
Marked as helpful0 - @sdnitrogenSubmitted almost 3 years ago
My last challenge solution was using CSS Flexbox and this time I've used CSS Grid for this challenge as this layout seemed to be a nice one to implement inside grids. I didn't use grid-areas for this one which I'm still not very comfortable with using but will attempt to use it in my upcoming challenges. I've added an additional tablet layout between the mobile and desktop ones. Please let me know if you have any feedback or suggestions :)
@DavidEmad01Posted almost 3 years agoVery Nice Work With simple animation 😍
Keep Going ✌✌✌
1 - @andrecausinggSubmitted almost 3 years ago
Give some feed back on my mistake
@DavidEmad01Posted almost 3 years agoNice Work
You can use hover for the social links
Keep Going ✌✌
0 - @melwyntSubmitted almost 3 years ago
Hi! Thanks for checking my submission. For this project I tried my best to make this pixel perfect. I used SASS and you can find the code in the git repo.
Let me know how you think this can be improved.
Thanks!
- @jaklyk2103Submitted almost 3 years ago
https://codesandbox.io/s/reverent-haslett-whjmo
@DavidEmad01Posted almost 3 years agoNice Work
You can use for the button:
- curser: pointer;
Keep Going ✌✌
Marked as helpful0 - @E1000oSubmitted almost 3 years ago
SInce the size of the card is more or less the same for desktop and mobile version, I have used mainly px for heights and widths. The background is a bit off, but at the end of the day I think it's ok. Any comments appreciated. Love
@DavidEmad01Posted almost 3 years agoPerfect Job 😍😍😍
Continue Coding ✌✌
Marked as helpful0 - @elams18Submitted almost 3 years ago
Hi all, after the feedback for the layout, I changed the positioning by using Flex box. Just one query, how do you decide on the sizes of the cards and the like?
Thank you.
@DavidEmad01Posted almost 3 years agoNice Work
You can use this for the button:
- border: none;
Keep Going ✌✌
Marked as helpful1 - @shahidafridi23Submitted almost 3 years ago
feel free to give your feedback or suggestion, thanks in advance!
@DavidEmad01Posted almost 3 years agoGood Job
But check the responsive for mobile,, as you can use some padding
Continue Coding ✌✌
Marked as helpful0 - @strosiSubmitted almost 3 years ago
I have no exact question, just wondering if the code is correct and how the end result looks on different devices.
@DavidEmad01Posted almost 3 years agoNice Work
I think the code is correct,, You can try more challenges for more experience 😍
Keep Going ✌✌
Marked as helpful0
