Design comparison
Solution retrospective
Please feel free to provide feedback on my code. That will lead me to more perfect way. Thank you ~
Please log in to post a comment
Log in with GitHubCommunity feedback
- @zeerobit
Looks good.. only thing i'd suggest is to replace the px for rem mostly for the width, padding, margin and font-size since px is not scalable
Happy coding !!!
Marked as helpful - @bdarab
Thanks for your comments on my solution. I keep it in mind for future challenges. Your solution is very identical to the Frontend directions & the sample. Congratulations.
Marked as helpful - @DavidEmad01
Very Nice Work 😍😍😍
Continue the challenges and keep going ✌✌
Marked as helpful - @zaybali
Really nice work there with this solution, I would love to thank you for your feedback and suggestions, they were really helpful, I fixed most of the issues you said on my solution, just can't get hover color property working.
Marked as helpful - @cacosted
Hello @tymren608 I really liked your solution and appreciate your feedback on mine's I will take your advice in consideration.
My tip for you is that you use the :root pseudo class to keep variables for your colors, in that way you can change them easily without having to change it in all places
Marked as helpful - @origuy
HI,
I reviewed your code and saw the BEM the code look very clean and easy to understand keep up with the great work !
one thing I would suggest is to work with rem unit or em unit they are relative units which can help you for more advanced work
Marked as helpful - @Abdulrahman14Salah
Good Job Bro , Keep Going
- @Lshiroc
How did you set up your github page website? When I try to open a github page for a repository it open gh-page tree. I can't reach main.
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord