My First Solution on Chanllenge

Community feedback

• 

  Jean Guillet•40

  @John35961Posted almost 3 years ago

  Very nice, clean and accurate!

  Marked as helpful

  1
• 

  Heli0s•670

  @zeerobitPosted almost 3 years ago

  Looks good.. only thing i'd suggest is to replace the px for rem mostly for the width, padding, margin and font-size since px is not scalable

  Happy coding !!!

  Marked as helpful

  1
• 

  Bina Darabzand•40

  @bdarabPosted almost 3 years ago

  Thanks for your comments on my solution. I keep it in mind for future challenges. Your solution is very identical to the Frontend directions & the sample. Congratulations.

  Marked as helpful

  1
• 

  David Emad•925

  @DavidEmad01Posted almost 3 years ago

  Very Nice Work 😍😍😍

  Continue the challenges and keep going ✌✌

  Marked as helpful

  1

  ---

  

  Web Wizard•5,690

  @rsrclabPosted almost 3 years ago

  Thank you very much, @DavidEmad01 ~

  1
• 

  Zaib Ali•90

  @zaybaliPosted almost 3 years ago

  Really nice work there with this solution, I would love to thank you for your feedback and suggestions, they were really helpful, I fixed most of the issues you said on my solution, just can't get hover color property working.

  Marked as helpful

  0

  ---

  

  P

  Jeremiah Lateef•160

  @jeremiahlateefPosted almost 3 years ago

  @iamzakofficial You can check out my code on the solution for how to set the hover color property on the image. It's a little bit complicated so I can't explain it here.

  1
• 

  cacosted•570

  @cacostedPosted almost 3 years ago

  Hello @tymren608 I really liked your solution and appreciate your feedback on mine's I will take your advice in consideration.

  My tip for you is that you use the :root pseudo class to keep variables for your colors, in that way you can change them easily without having to change it in all places

  Marked as helpful

  0
• 

  Ori Guy•110

  @origuyPosted almost 3 years ago

  HI,

  I reviewed your code and saw the BEM the code look very clean and easy to understand keep up with the great work !

  one thing I would suggest is to work with rem unit or em unit they are relative units which can help you for more advanced work

  Marked as helpful

  0
• 

  Abdulrahman•60

  @Abdulrahman14SalahPosted almost 3 years ago

  Good Job Bro , Keep Going

  0
• 

  Zeynal Mardanli•180

  @LshirocPosted almost 3 years ago

  How did you set up your github page website? When I try to open a github page for a repository it open gh-page tree. I can't reach main.

  0

  ---

  

  Zeynal Mardanli•180

  @LshirocPosted almost 3 years ago

  @Lshiroc whatever I found it. I just forgot to save after choose main branch:D

  0