Skip to content
OverviewSolutions
25
Comments
16
Dark-Lover
@Dark-Lover

All comments

  • Dark-Lover•735
    @Dark-LoverPosted over 2 years ago

    you did a great job.

    you can refactor code and try to show thumbnails dynamically instead of hardly coding div 4 times

    className={classNames('rounded-xl', { ...... in "ModalProduct.tsx"

    keep coding.

    Marked as helpful
    0
  • Ponnusamy•250
    @ponnusamy-krishSubmitted over 2 years ago

    I thought it was hard, But it turns out easier. The lightbox part was little bit hard, Even though it was hard, I did it without using any framework or libraries... share your thoughts.....

    E-commerce landing page

    2
    Dark-Lover•735
    @Dark-LoverPosted over 2 years ago

    each challenge even junior ones could be hard if u want to make it pixel perfect. u did a great job.

    try to fix responsiveness

    Marked as helpful
    0
  • Dark-Lover•735
    @Dark-LoverPosted over 2 years ago

    great work, i like the animation.

    it would be better if u add cursor pointer to Links not only navbar items.

    keep coding.

    1
  • Gareth Carter•235
    @gcarter89Submitted almost 3 years ago

    This is my second submission for this challenge.

    While I fulfilled the brief for the project, I wanted to give myself the additional challenge of fulfilling the requirements using a single call to the API.

    Rather than calling the API multiple times for fetching country details and when navigating back to the main list of countries. I wanted to have one persistent piece of state that could manage everything.

    In the previous submission, I found myself dealing with bad request handling. After a number of calls - potentially down to API call throttling. I found a single call to the API satisfied everything I needed to do. It's made the initial load a little longer, but the navigation and use of the app, very fast afterwards. I'll probably filter the fields in each API request later.

    In my next submission, I'll look at component-ising things more!

    Any questions or improvements, let me know!

    Second Attempt at REST Countries API. App now uses only 1 API call.

    4
    Dark-Lover•735
    @Dark-LoverPosted almost 3 years ago

    i like your solution

    what u said is what everyone should do, minimize as possible api calls, cuz in real world projects more requests means paying more money. and in this project a single call is enough, u can then filter from it all the data u need in every component.

    keep coding

    Marked as helpful
    0
  • Dark-Lover•735
    @Dark-LoverPosted almost 3 years ago

    hey my friend

    i like your solution, everything seems to be working well..

    the only issue u may have to fix is the responsiveness on 800 to around 850 px where things are

    mixed up (Technology component).

    good job

    0
  • Dark-Lover•735
    @Dark-LoverPosted about 3 years ago

    i like your solution. if u dont mind, i would like to have some advices from u. if u agree let me know.

    happy coding

    0
  • gearboz•360
    @kunsansangSubmitted about 3 years ago

    There's still a bug that I haven't fixed yet. When filtering more than one times without clear the current filter then the issues will comes. I am hopefully you guy can let me know where did I miss something, what do you think about this solution. Thanks alot.

    live searching and filter using vanilla js

    2
    Dark-Lover•735
    @Dark-LoverPosted about 3 years ago

    u can use just one function, something like this:

    filterData(region,data){

    let newData= data.filter((element)=> element.region === region);

    return newData;

    }

    newData will contain only countries that passes the condition, in this case, only countries form that region will be returned.

    this is just a way of doing things. u may find a better way.

    0
  • Dark-Lover•735
    @Dark-LoverPosted about 3 years ago

    hey my friend, nice try on this challenge. everything works great, one issue i have found was that in many component u fetch data again, while u can do it once and use it everywhere without consuming all the queries (fortunately this api doesn't have a limited query number). keep coding :)

    0
  • gearboz•360
    @kunsansangSubmitted about 3 years ago

    There's still a bug that I haven't fixed yet. When filtering more than one times without clear the current filter then the issues will comes. I am hopefully you guy can let me know where did I miss something, what do you think about this solution. Thanks alot.

    live searching and filter using vanilla js

    2
    Dark-Lover•735
    @Dark-LoverPosted about 3 years ago

    hey, nice try.. to fix that problem, try to refactor the filter function u have used. the best way is the take a copy of the array containing all countries data and try to filter them using the Js filter method Array.prototype.filter() so that it will return only countries that have region === to region clicked by the user. i hope that was helpful. keep coding :)

    0
  • Dark-Lover•735
    @Dark-LoverPosted about 3 years ago

    hey my friend, i like you solution, you did a great job. i was working on the same challenge so iv noticed that border countries for china or russia makes the UI ugly. check it and try to fix it. keep coding

    1
  • Dark-Lover•735
    @Dark-LoverPosted about 3 years ago

    hey my friend, i like your solution. im learning react, im a beginner , i checked your code and iv noticed that in the detailPage.js u have used a lot of useState, i wonder why u didnt use useReducer instead ?

    Marked as helpful
    0
  • Dark-Lover•735
    @Dark-LoverPosted over 3 years ago

    pretty cool solution, i like the flip animation. this is my solution. https://www.frontendmentor.io/solutions/launch-countdown-timer-with-html-sass-and-vanilla-js-B7ALo9Gxq im new to sass, if u have time check it and give me some feedbacks. i appreciate it. thank you.

    0