Hello Community, This is another project I completed, I would very much appreciate honest feedbacks and corrections. THANK YOU ALL.
Dan Kant
@Dan-KantAll comments
- @Luscious258Submitted over 2 years ago@Dan-KantPosted over 2 years ago
Hello dude, the implementation is great, but the thing you lack in is hover effects. Couldn't you manage to write hover effects or you just didn't want to ?
Marked as helpful0 - @kaykaym01Submitted over 2 years ago
What are best practices for sizing elements ?
Should I still use layouts like flexbox and css grid for even simple sites like this one ?
@Dan-KantPosted over 2 years agoGood day Kayla, here are some ways you can improve your code. In order to center an element both horizontally and vertically give your body or a parent element min-height: 100vh; display: flex; justify-content: center; align-items: center; . Now, to proceed with your questions. You can use relative size units like rem, em with max-width which will adjust to the viewport. As for your following question, yes, you should Flexbox or Grid if you want to position elements responsively.
Marked as helpful1 - @WildSpaceCadetSubmitted over 2 years ago
project 3, struggled with vertical alignment and sizing as the page size changes. if anyone can give advice would be very much appreciated, i also think having 3 flexbox's is not good practice..
alos the hover state over the button comes up with the edit cursor and not the click cursor how do i fix this?
@Dan-KantPosted over 2 years agoGood day buddy, here are some suggestions to tackle some of your issues · Set min-height: 100vh; to your body to vertically align your card. · You gave your card width: 50vh; vh stands for view height, but you are using it with width property. I suggest using max-width and using relative units like rem. Moreover, could you specify your last issues?I guess we can combat it with more clarity
Marked as helpful0 - @vanee17Submitted over 2 years ago
Cambiando un poco el estilo!
@Dan-KantPosted over 2 years agoYour order card is very original. Keep up the great work
Marked as helpful0 - @assem-frontdevSubmitted over 2 years ago
- I struggle a bit when trying to centre the box both horizontally and vertically using flexbox and my question is: are there any other options to centre the element without giving the container 100vh?
- I would appreciate your feedback on my work );
@Dan-KantPosted over 2 years agoGood day Assem. I also had the problem centering the box. However, I solved it by setting both html and body's widths and heights to 100% and then by applying flexbox properties I positioned it to the center of the viewport. Give it a try. I'll be delighted if I could be of use.
0