@aouintihouari
Submitted
@Carlosaac23
@aouintihouari
Submitted
@Carlosaac23
Posted
Hi Buddy! Well done with the page structure! Here are some tips I'll give to you to improve your page
:root {}
in your style file to put there all of your main colors and use them on the page. As you can see, the background-color
of your recipe is rose while the design is white.font-family
of your preparation section and change the font-size
of your headings. Try to use rem
instead of px
.@hugodelmiranda
Submitted
@Carlosaac23
Posted
Hi Hugo. You did it very well. Even though, I'll give you some recommendations to improve your final design.
padding
to your <div class="container">
so that the elements inside don't look so tight.<button type="button">GitHub</button>
you should use <a href="#">GitHub</a>
to make the page more accessible. This is also a good practice to use <a>
tags for links.Marked as helpful
@Carlosaac23
Posted
Hi @josemills. I saw your challenge and you did very well with the design. There are some tips I wanna give you to remove your scrollbar and have your card centered. Instead of using height: 200vh
, use height: 100vh
. 2 - Another thing, I saw your code and you use a lot div
in your HTML. Try to use less and it'll be easier to style it. 3 - Reviewing your code I saw you used <button><strong>Learning</strong></button>
to make your text bold. It works but it's not the best practice. Try to style it in the style.css
. Try them and let me know if you solve that!
@Darice19
Submitted
What are you most proud of, and what would you do differently next time?
Completing my first one and overcoming any anxiousness with it.
What challenges did you encounter, and how did you overcome them?
The biggest challenge was going through git and I was able to overcome it through learning.
What specific areas of your project would you like help with?
Anything that can take my project to the next level
@Carlosaac23
Posted
Hi David. Congratulations on completing your challenge! I have some improvements you could implement in your challenge.
<div class="attribution">
.<div class = "card">
in the <main>
tag to improve your accessibility.