Skip to content
OverviewSolutions
4
Comments
4
Carlosaac23
@Carlosaac23

All comments

  • Carlosaac23•60
    @Carlosaac23Posted about 2 months ago

    Hi Buddy! Well done with the page structure! Here are some tips I'll give to you to improve your page

    1. You can use :root {} in your style file to put there all of your main colors and use them on the page. As you can see, the background-color of your recipe is rose while the design is white.
    2. You can try to change the font-family of your preparation section and change the font-size of your headings. Try to use rem instead of px.
    0
  • Carlosaac23•60
    @Carlosaac23Posted about 2 months ago

    Hi Hugo. You did it very well. Even though, I'll give you some recommendations to improve your final design.

    1. You should add padding to your <div class="container"> so that the elements inside don't look so tight.
    2. I saw your link elements and instead of using <button type="button">GitHub</button> you should use <a href="#">GitHub</a> to make the page more accessible. This is also a good practice to use <a> tags for links.
    3. Once you have improved your links. You should add some padding to make them more similar to the design.
    Marked as helpful
    0
  • Carlosaac23•60
    @Carlosaac23Posted about 2 months ago

    Hi @josemills. I saw your challenge and you did very well with the design. There are some tips I wanna give you to remove your scrollbar and have your card centered. Instead of using height: 200vh, use height: 100vh. 2 - Another thing, I saw your code and you use a lot div in your HTML. Try to use less and it'll be easier to style it. 3 - Reviewing your code I saw you used <button><strong>Learning</strong></button> to make your text bold. It works but it's not the best practice. Try to style it in the style.css. Try them and let me know if you solve that!

    0
  • David Rice•10
    @Darice19Submitted about 2 months ago
    What are you most proud of, and what would you do differently next time?

    Completing my first one and overcoming any anxiousness with it.

    What challenges did you encounter, and how did you overcome them?

    The biggest challenge was going through git and I was able to overcome it through learning.

    What specific areas of your project would you like help with?

    Anything that can take my project to the next level

    QR Code

    2
    Carlosaac23•60
    @Carlosaac23Posted about 2 months ago

    Hi David. Congratulations on completing your challenge! I have some improvements you could implement in your challenge.

    1. To improve your card design you can remove the div with the class 'attribution' <div class="attribution">.
    2. I don't know if you don't see it but the 'style-guide.md' file tells you what type of font you should use. Check it again and try.
    3. You can wrap your main div <div class = "card"> in the <main> tag to improve your accessibility.
    0