Submitted 11 days ago

QR Code

David Rice• 10

@Darice19

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Completing my first one and overcoming any anxiousness with it.

What challenges did you encounter, and how did you overcome them?

The biggest challenge was going through git and I was able to overcome it through learning.

What specific areas of your project would you like help with?

Anything that can take my project to the next level

Community feedback

Carlosaac23• 60

@Carlosaac23

Posted 11 days ago

Hi David. Congratulations on completing your challenge! I have some improvements you could implement in your challenge.

To improve your card design you can remove the div with the class 'attribution' <div class="attribution">.
I don't know if you don't see it but the 'style-guide.md' file tells you what type of font you should use. Check it again and try.
You can wrap your main div <div class = "card"> in the <main> tag to improve your accessibility.

Steven Stroud• 4,120

@Stroudy

Posted 11 days ago

Hey, Great job with this solution you should be proud, A few things I noticed,

Missing a <meta> description tag for SEO purposes,
Setting a height and width attribute to your <img> will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image,
It is best practice to have a <main> tag inside your body highlighting the main section.
Background and foreground colours do not have a sufficient contrast ratio(div.card p), Low-contrast text is difficult or impossible for many users to read. Check out this Discover and fix low-contrast text with Chrome DevTools,

Great CSS, I hope you found some of this information helpful, You should give the article a good read and I look forward to seeing some more from you, Happy coding! 💻

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord