QR Code

Community feedback

• 

  Carlosaac23•60

  @Carlosaac23Posted about 2 months ago

  Hi David. Congratulations on completing your challenge! I have some improvements you could implement in your challenge.

  1. To improve your card design you can remove the div with the class 'attribution' <div class="attribution">.
  2. I don't know if you don't see it but the 'style-guide.md' file tells you what type of font you should use. Check it again and try.
  3. You can wrap your main div <div class = "card"> in the <main> tag to improve your accessibility.

  0
• 

  P

  Steven Stroud•11,890

  @StroudyPosted about 2 months ago

  Hey, Great job with this solution you should be proud, A few things I noticed,

  • Missing a <meta> description tag for SEO purposes,
  • Setting a height and width attribute to your <img> will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image,
  • It is best practice to have a <main> tag inside your body highlighting the main section.
  • Background and foreground colours do not have a sufficient contrast ratio(div.card p), Low-contrast text is difficult or impossible for many users to read. Check out this Discover and fix low-contrast text with Chrome DevTools,

  Great CSS, I hope you found some of this information helpful, You should give the article a good read and I look forward to seeing some more from you, Happy coding! 💻

  0