Skip to content
OverviewSolutions
16
Comments
2
Christian Camilo Beltran Fonseca
@CamiloBeltran24

All comments

  • Łukasz Lubaszewski•120
    @luckyszakul0Submitted 28 days ago
    What are you most proud of, and what would you do differently next time?

    The speed at which I'm doing these small projects is slightly faster each time, while more or less keeping the quality of my work.

    What challenges did you encounter, and how did you overcome them?

    I don't think there is anything mentioning here.

    What specific areas of your project would you like help with?

    I would really appreciate some feedback on the use of my 7-1 pattern in SCSS files, as I sometimes don't know where to put a specific file. I know this doesn't make sense to use the pattern for such a small project, but I wanted to give it a go. Also, I tried using the BEM naming combined with kebab case for SCSS class names, but I don't think I did a good job with that.

    Social links profile made using SCSS and partial 7-1 pattern

    1
    Christian Camilo Beltran Fonseca•170
    @CamiloBeltran24Posted 26 days ago

    Hi @luckyszakul0 ! Great job on this project!

    I think reorganizing your folders a bit could make your structure even cleaner. Try moving your design, scss, and css folders into the assets folder. This way, all your static resources—like styles, images, and designs—are in one place, which makes everything easier to find and manage as your project grows.

    Also, it looks like there are quite a few files here for a project this size. Simplifying a bit could make it easier to navigate and keep tidy, especially if you're working with others.

    Awesome work overall—keep it up!

    0
  • Christian Camilo Beltran Fonseca•170
    @CamiloBeltran24Posted 27 days ago

    Hi Pablo ! Great Job ! From what I can see of the site, great job overall ! You’re doing really well. Here are a few accessibility suggestions to consider as you keep improving:

    • Try to use header tags in semantic order, starting with an h1 rather than jumping directly to an h5. This helps screen readers better understand the content structure.

    • Consider using aria-labels and avoiding empty links, as these elements improve accessibility and provide a better experience for all users.

    It looks like there’s an issue with your GitHub link, so we’re unable to view your code and provide full feedback. I recommend checking it so you can get input from the community.

    Keep up the great work, and best of luck with the project!

    0