HualDev• 850
@HualDev
Submitted
I would like to know your comments that help me to improve my skills
Caio Couto
@CaioCouto
All comments
- Caio Couto• 150
@CaioCouto
Posted
Hello, there!
Good job! I noticed 03 things that you may want to give some attention:
- The width of your main element, like the other commenter said.
- The font seems to be a little off, maybe you could try adding the specified font from Google Fonts and importing it into your project with a
<link/>element into the HTML'sheador with a@importin CSS. - In you CSS, you could try grouping all properties a certain element is going to get into a single (there's a
pelement with two blocks of code for it). - Also, check out the font-weight property. It controls the thickness of your font.
0 - Dimitar Radev• 930
@Mitko90
Submitted
This is my attempt for a solution to the News Homepage challenge.
I really know absolutely nothing about javascript so I followed this tutorial on how to make the menu work.
Of course all suggestions are very welcome but I have one question about the CSS grid:
- Is it possible to add different size gaps between grid elements? I used mainly margins because the design had gaps of various sizes.
As always thank you to anyone who takes the time to look and correct my code.
Caio Couto• 150@CaioCouto
Posted
Hello, there.
Even without knowing JavaScript, you got it to work. Nice job on your solution!
About you question, according to this answer on StackOverflow: "[...] you cannot apply different widths to different gaps. [...] You could use margins (or padding) to show extra space, but this doesn't actually change the width of the gap. It only expands the row."
On the other hand, you can set different
gapvalues to rows and columns individually. For example:row-gap: 1remsets a1remgap between all the rows.column-gap: 1remsets a1remgap between all the columns.gap: 1rem 1rem //gap: row-gap column-gapdoes the same as the other two, but in one line.
I hope this information was helpful in some extent. :)
Marked as helpful
0
