@mrnestorramirezSubmitted 9 months ago
Hope you like it!
Please, be completely honest where i need to focus to improve.
Caaspita
@CaaspitaAll comments
- @CaaspitaPosted 9 months ago
Congratulations on a new solution, the code looks very clean. One thing that could be improved as a good practice is to change the <div> to a <section> or <article> to maintain semantic HTML. But honestly, everything looks very neat.
1 - @jabnakarSubmitted 9 months ago
Hey there! 👋 Just finished working on a social links card visual for a Frontend Mentor challenge. I'd really appreciate your feedback on the HTML and CSS code. Specifically looking for thoughts on the overall design, how it renders on different screens, and any ideas on code improvement. If you notice any have tips on best practices, I'm all ears! Thanks a bunch for your time and input!
@CaaspitaPosted 9 months agoCongrats for the new solutions, i have some sugestions for you.
-It would be good to separate the CSS and the HTML into different files to maintain good practice and more organized code.
-Try to maintain correct indentation in the code so that it is easier to read it for you and other people
-You could improve good practices by using semantic HTML so that the browser can read your website better. I leave you this page that explains it better. https://www.freecodecamp.org/news/semantic-html5-elements/
Cheer up and keep programming
Marked as helpful1 - @lkBangarSubmitted 9 months ago
What did you find difficult while building the project? The difficult part was to add padding and margin pixels to make the design similar to the given design images. It would have been much easier if those instructions were also given in the ReadMe.md file.
Which areas of your code are you unsure of? I doubt the media query that I used, as I used flex-box which inherits responsive behaviour, but I have a few doubts regarding the responsiveness.
@CaaspitaPosted 9 months agoThe page looks very good, but I have some suggestions for you.
-It would be good to separate the HTML and CSS code into different files to maintain order. While it may not be much, it is more organized.
-The <h2> tag could be used as <h1> since it is the main topic, helping the browser better understand the theme of your page and display it to the correct users.
-As Mark mentioned, the use of semantic HTML is a good practice as it helps the browser better understand your code.
Congratulations on completing this challenge! Best of luck, and keep improving.
0
