TCO932• 220
@TCO932
Submitted
P
CHBNDJ
@CHBNDJ
All comments
Nice project overall but try in the desktop version to put a margin between the header and your main. Also regarding your mobile version you can try to put a transition for your toggle menu and also try to make it appear for the right instead from the left. Here what ive done
nav { width: 65%; height: 100vh; position: absolute; top: 0; right: 0; display: flex; justify-content: center; align-items: center; background-color: #FFFDFA; margin-right: -100%; transition: margin-right .5s ease; z-index: 1000; }
nav.open-menu { margin-right: 0; } by default the nav menu is in margin right -100% when i click to the icon menu the nav come until the margin-right is 0. Cheers. :)0- PMohd Sadaf• 460
@MsadafK
Submitted
nice work overall maybe try with a reduce width but the main point and problem have been resolved congrats :)
0 - PMohd Sadaf• 460
@MsadafK
Submitted
change the color of your submit add padding to your button number and reduce the gap between your buttons. Maybe you can try at least thats what ive done to click outside of the modal and it will bring us back to the the intro choices. great work :)
0 - PMartin Šikula• 380
@sikulamartin
Submitted
nice job congrats i try your code and i didnt see the response i give you seems to have forgot the focus on your response thats the only big think you forget in my view. :)
0 - PAaron Smith• 280
@medic-code
Submitted
What are you most proud of, and what would you do differently next time?
Proud to complete my first intermediate project. The javascript was pretty interesting to get into and lots of different aspects to consider. I'm not sure there is much I'd do too differently, i decided to do the JS first which helped. There was a bit of changing of html and js after styling though, not too sure if that could've been helped.
What challenges did you encounter, and how did you overcome them?
Not too much challenges really, had a bit of trouble getting the custom input radiobox to style, and spent quite a bit of time trying to get the differences in sizes between tablet and mobile set up.
What specific areas of your project would you like help with?
HTML Semantnics
CSS methodology and approach
JS syntax and conciseness.
hi nice job overall just take a look at your slider the green color should not be there when there is no number at the character length try someting like that slider.addEventListener('input', (e) => { myValue.textContent = e.target.value;
let mouse = slider.value; let color = `linear-gradient(90deg, rgba(164, 255, 175) ${mouse*5}%, rgb(24, 23, 31) ${mouse*5}%)`; slider.style.background = color;}); play with the linear gradient in your css with 50% of green and 50% of black then do the JS above.
good luck :)
0 - PAnton Vasilache• 580
@Antonvasilache
Submitted
What are you most proud of, and what would you do differently next time?
- JavaScript part was pretty easy, despite handling multiple inputs of different types
- Managed to implement a bit of reusability in the code
- Would probably think more about form validation to make sure it's properly covered
What challenges did you encounter, and how did you overcome them?
- Some of the input styles were challenging, but nothing a few more divs can't fix
- Naming the CSS classes due to how deep the HTML tree became - I used some element selectors to cover for that
What specific areas of your project would you like help with?
There is probably a better way of storing the state, I tried to use an object, but didn't do much with it in the end.
nice work overall just check the width and the height of your elements and the position of them also + the splitter
1 - Si1entERA• 450
@Si1entERA
Submitted
What are you most proud of, and what would you do differently next time?
The completion of the project and improving my understanding with json and fetch.
What challenges did you encounter, and how did you overcome them?
Instead of creating multiple cards in HTML and using Json to manipulate the data within each one, I decided to use JavaScript to dynamically add the cards with the Json data. This also meant I had to make changes to data.json and add 'key, color and images' and its associated values.
The reason why I took this approach is because, if you wish to add or remove the cards, you can just alter the data.json file.
What specific areas of your project would you like help with?
Any and all feedback is welcomed.
Nice job my friend just if you have time checkout the size of your card to be as close as possible of the design :)
0 - Satyam Vyas• 150
@SatyamVyas04
Submitted
Hi my friend first of all great job just about your img checkout in the figma file the width and the height of the picture same as with your both input.
Best regards
0 - S-LoCascio• 90
@S-LoCascio
Submitted
What are you most proud of, and what would you do differently next time?
Figuring out the Javascript was quite fun actually. I also was very happy continuing the work with my padding and margins.
What challenges did you encounter, and how did you overcome them?
The share box was a giant PITA. Additionally, dealing with the image size was a hassle, but I now know about object positioning a lot better. Getting the share button to work was also a hassle and at one point I soft-key gave up when it was "good enough."
What specific areas of your project would you like help with?
Figuring out how to deal with SVG files. I followed a few tutorials but none of them worked for my project. I'm guessing it had something to do with how I nested things but still. yeah. I also couldn't think of how to remake the div on the mobile client with the share materials to include the share button.
good job overall the overall design is good how did you manage for the click on the button ?
0 - Pbluepersia• 1,055
@bluepersia
Submitted
Very good overall just check the position or the height of each element but its not that important but your footer need to have some opacity to it and an object fit cover to it good work
0 - ana-lsm• 80
@ana-lsm
Submitted
What are you most proud of, and what would you do differently next time?
Learning how to use grid.
I would repeat the process using flex box, just for practice
What challenges did you encounter, and how did you overcome them?
Centering the html
What specific areas of your project would you like help with?
With the responsiveness of the web page.
hi my friend look at the height of every container you will be able to have the exact size as the design good job :)
0
