Skip to content
OverviewSolutions
11
Comments
3
Burim Palloshi
@BurimP

All comments

  • Burim Palloshi•230
    @BurimPPosted over 1 year ago

    Excellent work!

    1
  • Burim Palloshi•230
    @BurimPPosted over 1 year ago

    Hi!

    //use "*" to select all elements

    • {
      margin: 0; padding: 0; box-sizing: border-box; //helps with calculating total width and height of an element. }

    Use more descriptive class/id names, in a bigger project it helps to navigate your code more easily. The div "code-one" is unnecessary in this case, you could have used body instead.

    Marked as helpful
    0
  • Rob Simpson•490
    @pertrai1Submitted over 1 year ago

    Could not get the image to scale correctly in desktop. No matter what the perfume would always scale up and if I tried to make it smaller, the whole image would get smaller. Any help would greatly be appreciated.

    Basic HTML/CSS

    2
    Burim Palloshi•230
    @BurimPPosted over 1 year ago

    Hi Rob! I fixed the issue and made a pull request, you can go on git hub and check it out.

    Marked as helpful
    1