@ajkun55Submitted 7 months ago
P
Benhemin
@BenheminAll comments
- @BenheminPosted 6 months ago
You did a great job on making it look really close to the design good job!
If you want to go back and touch it up, somethings I notice are the lack of a box shadow on the main card, and the proportions of the 2 columns are slightly off compared to the design.
Marked as helpful0 - @luccyyy97Submitted 7 months agoWhat are you most proud of, and what would you do differently next time?
/
What challenges did you encounter, and how did you overcome them?/
What specific areas of your project would you like help with?not sure why site view on git-hub altered my top-image size become particularly small. however when view through visual code the image look exactly like I wanted.
@BenheminPosted 7 months agoI see the page isn't the entire size of the viewport. You should set your HTML and Body HTML tags to width/height : 100%, so that for every screen size the page will take up the entirety of it!
0 - @lifeguard1Submitted 7 months ago@BenheminPosted 7 months ago
You handled the core issue, that being CSS Grid. Good work!
0 - @RegexRiddlerSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I'm glad I figured out how to properly layout the cards using grids.
What challenges did you encounter, and how did you overcome them?I started laying out the cards uting flex, but adjusting them so the ones on the left and right side where offset/centered became impossible so I had to use grid instead.
What specific areas of your project would you like help with?Any feedback is much appreciated :)
@BenheminPosted 7 months agoLooks great! I really like how you handled the dynamic font sizing, I haven't begun to do that yet.
Your code is very clean and readable. Good job and keep up the good work!
0 - @JaviVaSuSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
.
What challenges did you encounter, and how did you overcome them?.
What specific areas of your project would you like help with?.
- @noribrraSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
nor
What challenges did you encounter, and how did you overcome them?nor
What specific areas of your project would you like help with?nor
- @JayapreethiNSubmitted 7 months ago@BenheminPosted 7 months ago
You should use the design template resources. They will make completing the projects much easier, guaranteeing each finished project looks clean.
If you are putting your own spin on the styles then I would also suggest leaving less empty space. You can fully center your items with justify-content: center, for the css container whose content you want to center.
Keep working hard!
Marked as helpful0 - @hallmesSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
N/A
What challenges did you encounter, and how did you overcome them?N/A
What specific areas of your project would you like help with?N/A
- @AdkasySubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
