@BelaGereon
@NatteeN
Submitted
What are you most proud of, and what would you do differently next time?
Finish the project. And growing in progress.
What challenges did you encounter, and how did you overcome them?
It was fun to do a front-end project
@BelaGereon
Posted
Very nice job overall!
Maybe for the next project you could look into using native html tags instead of using divs with classes for every element. This could improve accessability for your application overall and would rank it higher in google-search results when you start building real websites. It's also a good habit to get into because of industry standards used :)
Marked as helpful
@Durgashankar-Bhandari
Submitted
@BelaGereon
Posted
Limiting the card width to be a bit smaller than it currently is would probably get the solution a bit closer to the design, or you could use a fixed aspect ratio to get a similar effect.
I really like that you used a css reset before styling the rest of the qr-code card.
Maybe you can try to extract variables for the colors and use them instead to make the code a bit more maintainable and readable for the future, but that is more of a personal preference of mine than a rule everyone should follow... Also to make the border-radiuses (is that the plural...?) a bit smoother between the outer card and the qr-code, you can look up the formula that is generally used to calculate the inner radius so it always follows the outer radius perfectly.
Pretty nice overall :)
