Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Created A QR Code page using basic HTML/CSS

@Durgashankar-Bhandari

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@BelaGereon

Posted

Limiting the card width to be a bit smaller than it currently is would probably get the solution a bit closer to the design, or you could use a fixed aspect ratio to get a similar effect.

I really like that you used a css reset before styling the rest of the qr-code card.

Maybe you can try to extract variables for the colors and use them instead to make the code a bit more maintainable and readable for the future, but that is more of a personal preference of mine than a rule everyone should follow... Also to make the border-radiuses (is that the plural...?) a bit smoother between the outer card and the qr-code, you can look up the formula that is generally used to calculate the inner radius so it always follows the outer radius perfectly.

Pretty nice overall :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord