All comments

• 

  Nathalia Santos•30

  @naathcsSubmitted over 2 years ago

  Any feedback on CSS and HTML structure is welcome. I'm trying to improve both so I can start using libraries and also Javascript.

  

  NFT Preview Card using Overlay

  4

  100
  

  Bartlomiej Dlugosz•140

  @BartyCodingPosted over 2 years ago

  Hi naathcs, I took some time to look at your solution and you did a great job!

  Also, I have some tips for improving your code:

  -Remove the margin from the container class and make the height 100vh to truly center the card in the middle of the page. -For the hover effect on the image you could make use of pseudo-classes like ::before to achieve the same effect. This will remove any extra clutter in your HTML. -For the decorative images like the clock and the Ethereum sign you should remove the alt text and add an aria-hidden="true" to make screen readers ignore this text as it doesn't serve much purpose. -You could also remove/comment out the attribution at the end as your not using it but it's still taking up space at the bottom for no reason. -You could also add a simple box-shadow to make it look a lot better. If you're unsure of how to do that then here's a great article about how they work. Link

  Overall you did great :)

  Hope this helps and happy coding!

  Marked as helpful

  2

  This comment has received 1 replyShow