Skip to content
OverviewSolutions
7
Comments
2
Atef Zaky
@AtefZaky

All comments

  • mihai2537•190
    @mihai3636Submitted about 1 year ago

    Hello!

    • I'm not entirely sure if the mobile responsiveness part could be considered as done only by the max-width trick that I applied on the container. The picture of the mobile design looked quiet the same to me so I thought that nothing should be done about it.

    • Also, I'm not sure if I used the information from style-guide.md correctly regarding the Desktop width. I just applied 1440px to the most outer container but it looks strange on my screen.

    • Please let me know if you have any tips about anything at all. I'd really like to learn more about good practices but I don't know where to go from here.

    Thanks for reading!

    QR card with basic css, flexbox and no js

    2
    Atef Zaky•180
    @AtefZakyPosted about 1 year ago

    Hello! congratulation on completing your first challenge 🤟

    I have some suggestions to make it better and I will try to answer your questions🔽

    • in the mobile view you should give some padding to the container to make space between the card and the browser window in extra small devices. and change the height: 100vh to min-height: 100vh like that when the device's height is small your content will take up its space and the scroller will appear

    • in this challenge, you don't need to give the container max-width because the content doesn't take the full screen but when you make this you will need to give the background color to the body or the parent of the container to see the background on a large screen.

    I hope this helps you, overall nice solution, happy coding 👨‍💻

    Marked as helpful
    1
  • Atef Zaky•180
    @AtefZakyPosted about 1 year ago

    Good job.., but you need more padding in the footer and the header, Increase the size of the logo in the header and footer and the size of links in the header, Make the heading in the first section and the testimonials section uppercase and you can give the first section min-height: 100vh like that when the device screen height is small your content will remain on its shape Good luck.

    Marked as helpful
    0