Skip to content
OverviewSolutions
4
Comments
4
Arpit Pandey
@ArpitTheSlayer

All comments

  • Arpit Pandey•80
    @ArpitTheSlayerPosted 24 days ago

    There are three problems with your code:

    1. You have set the height property of body tag to 100vh which is not good because it is making your website not show up how it should have. I think you were trying to use min-height property. Fix that.
    2. You only use Young Serif font for all the tags which is also not good. You should only use it for headings. For others use Outfit font.
    3. Your website is not responsive for mobiles, fix that as well.
    Marked as helpful
    0
  • Anahsqi•50
    @AnahsqiSubmitted 25 days ago
    What are you most proud of, and what would you do differently next time?

    I am most proud of how I successfully implemented keyboard accessibility and transitions for the social links profile project.Next time, I would allocate more time to exploring advanced CSS transitions and animations. While I managed to implement basic transitions effectively.

    What challenges did you encounter, and how did you overcome them?

    One of the main challenges was implementing effective keyboard accessibility for all interactive elements. I had to ensure that elements were easily navigable using the keyboard, which required careful adjustments to the tab focus outline to maintain aesthetics while providing clear visibility. To overcome this, I experimented with CSS properties for focus states, ensuring that the outline was both functional and visually appealing.

    What specific areas of your project would you like help with?

    I would love feedback on my code structure and organization. Any suggestions for improving readability, maintainability, or following best practices in HTML and CSS would be invaluable.

    Frontend Mentor - Social links profile solution

    1
    Arpit Pandey•80
    @ArpitTheSlayerPosted 24 days ago

    Your website looks good in every way I know. I have nothing to pick about it.

    0
  • Arpit Pandey•80
    @ArpitTheSlayerPosted about 1 month ago

    I have only seen two problems with your code:

    • The paragraph does have enough contrast ratio for users with bad eyesight.
    • You used px unit in majority of your code and since it is absolute unit, it will make it almost impossible to change the font size of the browser and still keep the layout good for those who need to enlarge texts.

    Use rem or em depending on situation for them. px should be used be only used when you need something to stay a fixed size no matter the font size the browser is using like the border of the card, box shadow of the card, etc.

    Marked as helpful
    0
  • SirJoy•30
    @Sirjoy1Submitted about 1 month ago
    What are you most proud of, and what would you do differently next time?

    FEEDBACKS ARE WELCOMED

    QR CODE card

    1
    Arpit Pandey•80
    @ArpitTheSlayerPosted about 1 month ago

    There are three you can improve on:

    1. The box-shadow is too dark you should use a lighter color to make it less jarring. And the background color of the body is a bit too light, the color given by Frontend Mentor is better.
    2. The contrast ratio of the paragraph element is not good, you should make it darker for people with poor eyesight.
    3. In your css file there are many empty media queries that are not necessary. Remove them since they just confuse others who review your code and is generally not seen as good practice.
    0