izma13• 150
@izma13
Submitted
Arpit Pandey
@ArpitTheSlayer
All comments
- Arpit Pandey• 50
@ArpitTheSlayer
Posted
I have only seen two problems with your code:
- The paragraph does have enough contrast ratio for users with bad eyesight.
- You used px unit in majority of your code and since it is absolute unit, it will make it almost impossible to change the font size of the browser and still keep the layout good for those who need to enlarge texts.
Use rem or em depending on situation for them. px should be used be only used when you need something to stay a fixed size no matter the font size the browser is using like the border of the card, box shadow of the card, etc.
Marked as helpful
0 - SirJoy• 30
@Sirjoy1
Submitted
What are you most proud of, and what would you do differently next time?
FEEDBACKS ARE WELCOMED
Arpit Pandey• 50@ArpitTheSlayer
Posted
There are three you can improve on:
- The box-shadow is too dark you should use a lighter color to make it less jarring. And the background color of the body is a bit too light, the color given by Frontend Mentor is better.
- The contrast ratio of the paragraph element is not good, you should make it darker for people with poor eyesight.
- In your css file there are many empty media queries that are not necessary. Remove them since they just confuse others who review your code and is generally not seen as good practice.
0
