Skip to content
OverviewSolutions
4
Comments
3
P
Arjen Combee
@ArCombee

All comments

  • Arjen Combee•50
    @ArCombeeSubmitted about 3 years ago

    Hello Members!

    My solution for the 4th challenge on frontendmentor. Just like the previous challenges, I had a lot of fun with coding this page. Hope I implemented the feedback I received correctly, did my best 👍.

    Still struggle with semantic HTML tags tough, there are so many options to choose from. So any tips?

    As before, all feedback is welcome because this is the way to learn fast. Thanks for your time and energy to look at my solution.

    O, I combined the three SVG-files into one SVG-sprite file. Thought this should reduce load time of the page, is this a correct assumption?

    Arjen

    3-column preview - CSS Grid and SVG sprite used

    2
    Arjen Combee•50
    @ArCombeePosted about 3 years ago

    First revision is a fact 👍. After the feedback I looked at the design files, the Figma design is different and has rounded borders on all the cards, they overlap slightly, so no bleed of underling card is visible.

    But when I look at the JPG files, or open the files in Adobe XD you don't see that. So refactoring was done, and... well let me know if it looks like the original (somewhat).

    I'm happy with the result, and learned new things altogether, and that is why I'm here on this service.

    Best Regards,

    Arjen

    0
  • Arjen Combee•50
    @ArCombeePosted about 3 years ago

    Hi loulou

    Nice!

    At breakpoint 1279px (tested in Firefox) I see some strange shift in the 3 card layout, this seems unintentional. Maybe look at what's is happening there? 👍

    (this project will be my next challenge 😀)

    0
  • Arjen Combee•50
    @ArCombeePosted about 3 years ago

    Thanks for all the feedback and tips, did a first refactor of this project and think it is better. Later this year I will look at the code again, maybe version 3 will emerge 👍🤔

    0