WaelBenseghir• 160
@WaelBenseghir
Submitted
Anas - Front End Developer student
@Anas-95
All comments
@Anas-95
Posted
I'm not a senior to give you a feedback and I'm still learning but well done!!
0- WaelBenseghir• 160
@WaelBenseghir
Submitted
@Anas-95
Posted
I'm not a senior to give you a feedback and I'm still learning but well done!! keep going!
0 - P-Lucas-S• 50
@P-Lucas-S
Submitted
What are you most proud of, and what would you do differently next time?
I'm most proud of how I implemented the responsive design using Flexbox. It allowed the layout to adapt beautifully to different screen sizes without the need for complex media queries. Next time, I would like to explore CSS Grid to see how it compares to Flexbox for this type of layout.
What challenges did you encounter, and how did you overcome them?
One challenge was ensuring the card remained centered on the page across various screen sizes. I overcame this by using a combination of Flexbox properties on the body element to center the card both horizontally and vertically. Additionally, I faced difficulties with the image scaling properly within the card, which I resolved by setting the image width to 100% and height to auto, along with maintaining aspect ratio using CSS.
What specific areas of your project would you like help with?
I would like feedback on the semantic HTML structure and how it can be further improved for accessibility. Specifically, I am interested in knowing if there are better practices for structuring the content within the card. Additionally, any suggestions on optimizing the CSS for better performance and maintainability would be appreciated.
@Anas-95
Posted
Hi Lucas, I had the same issue with the img card, well done! I Great solution for the card, I need to learn more flexbox and grid!
0 - TheAashay• 210
@TheAashay
Submitted
What are you most proud of, and what would you do differently next time?
Turning the attribution into a box which inverts the color of background and text when hovered over, it might be unnecessary but doing something of my own idea feels good.
What challenges did you encounter, and how did you overcome them?
Adapting to Git and GitHub's process to add, commit and push was initially challenging but now I'm comfortable with it.
@Anas-95
Posted
Hey Aashay,
I'm not a senior who can give you feedback, but seniors recommend using semantic HTML. I really like your design, especially the two buttons! Well done! And it's fully responsive too!
1
