Skip to content
OverviewSolutions
11
Comments
1
Amanuel Chaka
@AmanuelCh

All comments

  • Dushyant Goyal•260
    @goyal-DushiSubmitted 7 months ago
    What are you most proud of, and what would you do differently next time?

    Hi , I am really happy that after I initiated the challenge, I was able to complete it. Although having 3 years of in React, I always learn something new whenever I do such challenges.

    I gave my best to keep up with DRY principles and do clean code. But, there always scope of improvement. So, please feel free to suggest or comment anything new that could enhance this project further. I would be happy to work and accept contributions on the same :)

    Github Repo : LINK

    Project : LINK

    Other Challenges completed by Me : LINK

    What challenges did you encounter, and how did you overcome them?

    I didn't encounter much challenges, only tried to maintain clean code practices and keeping up with the DRY principles.

    What specific areas of your project would you like help with?

    I think enhancing the project by including more challenging features will not only increase my learning curve, but also make the project much better. So, I would really appreciate if you have any new ideas to make this project even better !

    REST API Countries Switcher with Theme Toggle

    1
    Amanuel Chaka•290
    @AmanuelChPosted 7 months ago

    Hey there @goyal-Dushi

    I liked your approach of using Typescript.

    If there would be any improvements, I would suggest is, give a specified equal amount of width for the country card. I have seen that you are using a max-width of 250px. It would be better if the cards have a uniform width. The error might also arise from the ⁣card image because the API doesn't respond with a same image width for all countries. So handle the image width too. Plus, give a lighter box-shadow for the cards. Besides that, it was nice ✌

    Marked as helpful
    0