Darlington Obiri Yeboahā¢ 220
@DARLINGTON-CG
Submitted
Amaefula Joel
@Amaefula-Joel
All comments
- Amaefula Joelā¢ 440
@Amaefula-Joel
Posted
Great work on this project. I noticed a few thing which you could sort out.
- the delete button which removes all the items from the cart isn't working.
- when the add to cart button is click, the number of items that was increases wasn't reset to zero.
- and the of items that can be added can't be more than 3. I was thinking you did this intentionally. But it might be better to not to restrict the number of items that can be ordered. Great work on this project.
0 - Successā¢ 280
@techmad60
Submitted
Really loved this one. It really tested my nerves and strong will as a developer. There were moments when I wanted to just give up the whole thing, but that'd be easy.
I learned more about positioning and also learned that the best way to be a programmer is by breaking the task into bits and also trying to be calm while working on a task.
Amaefula Joelā¢ 440@Amaefula-Joel
Posted
Well done on the good work you put in to this challenge. It must have been hard working on this cause I also spent a lot of time working on this. Just some things I noticed from the site.
- I'm viewing your site from my phone and noticed that if I am on the first slide and I press the previous arrow it doesn't take me to the last slide. Try tweaking your code so that it allows one to go to the last image on the slide.
- when I click on the plus icon to increase the number and when I press the button add to cart, it doesn't work when I click on other parts of the button like the colored part of the button. The add to cart only worked when I clicked on the text directly. This can be solved by adding the event listener on the element wrapping the cart icon and the text, so that it'll be more accessible.
- also make it so that once the add to cart is clicked, the number resets, so that the user knows that the cart has been updated.
- a user can't add more than 3 items to the cart
Other than that good job on this challenge
Marked as helpful
0 - Elaineā¢ 11,400
@elaineleung
Submitted
Just updated my solution as I realized that I had mistaken the highlighted bar to be the day with the largest amount, when in fact it should be the current day (as in, in real life). I also made the component responsive even at smaller sizes instead of just having two fixed widths; this normally is not so hard to do since content tend to be filling up the container, but in this content here is smaller than the container. To make sure the container doesn't collapse, I used the responsiveness of
flex-wrapto ensure it would be at the size I need.Amaefula Joelā¢ 440@Amaefula-Joel
Posted
I'm really interested in knowing how you make your solution match almost identically to the design. What app do use? If it isn't an app, how do you make the perfect comparison
1 - Sylvainā¢ 50
@sylverdrag
Submitted
Amaefula Joelā¢ 440@Amaefula-Joel
Posted
Good work with this. But I noticed a few things in this site. The bar in the middle is the one who have the different background color. The font size is smaller in the desktop view so you can try making it a little bigger. And the chart is causing the horizontal scrollbar to appear on the mobile view, so try to adjust the size of the bars to make room. Other than this I think your work is fine
0
