All fedback is welcome thanks you in advance
Ali-Tofiqi
@Ali-TofiqiAll comments
- @suhaib-mansoori963Submitted over 1 year ago@Ali-TofiqiPosted over 1 year ago
Hi coder
Congratulations on submitting your solution
your project is perfect, it seems that the image source you write isn't in your GitHub repository:
<img class="qr_code" src="./images/image-qr-code.png" alt="image-qr-code">change it to have a complete view in your preview site.
Good luck and happy coding
0 - @MarianastefanySubmitted over 1 year ago
O que você achou difícil ao construir o projeto? muito bom, achei ele bestante dinâmico e simples . Quais áreas do seu código você não tem certeza? na parte das div Você tem alguma dúvida sobre as melhores práticas? não
@Ali-TofiqiPosted over 1 year agoHi coder
Congratulations on submitting your solution
I check your preview site and it showed your README.md file it's because your HTML file in your GitHub repository is indexex.html. if you change the name of it to index.html your preview will be OK.
I hope this was helpful to you.
Good luck and happy coding.
Marked as helpful0 - @AttahirulSubmitted over 1 year ago@Ali-TofiqiPosted over 1 year ago
Hi coder
Congratulations on submitting your solution
it seems that you had a great code, I checked your preview site but it was just your HTML, you don't need to project zip file on your GitHub also it doesn't work there you must put your file in the same folder next to HTML file and these file paths
"
<link rel="stylesheet" type="text/css" media="screen" href="file:///C:/Users/tahir/Downloads/qr-code-component-main/qr-code-component-main/main.css">"doesn't work on GitHub because they're on your local computer. I think if change your file path and files on your GitHub repository can have an excellent project.
good luck and happy coding.
0 - @AndriiIladiiSubmitted over 1 year ago
Didn't have any problems here. If you have any remarks about my solution, please let me know, I'll give them attention
@Ali-TofiqiPosted over 1 year agoHello coder
Congratulations on submitting your solution
your code is perfect, I think it will be a good option to add the color background to your body element instead .main it can have a better look on a very small size of the screen because the entire page has one color.
Marked as helpful0 - @DarkR4gerSubmitted over 1 year ago@Ali-TofiqiPosted over 1 year ago
Hello coder
Congratulations on submitting your solution
I clicked on your preview site, and your card's text in three different browsers is a little uniform I think if you delete the height from your .container it will be excellent.
Marked as helpful1 - @Novex21Submitted over 1 year ago
Responsive is still needed to be fixed.
@Ali-TofiqiPosted over 1 year agoHello coder
Congratulations on your solution.
in your GitHub repository change the location of your file and put them in the first directory next to README.md so your GitHub pages can see the HTML file and show it in your live view because now it's showing your README.md file in your link.
1