Frontend Mentor | Alejandro Hernández Rosa's profile

@gianmromeroSubmitted over 2 years ago

Feedback is welcome I try to do this project with grid and flex but I can't. I hope someone tell me that is possible and how I can do that. Thanks.

Social proof section master with flex responsive

1

Alejandro Hernández Rosa•180

@AlexuvaPosted over 2 years ago

Hi @gianmisdev!

Nice job! The styles looks really similar!

About the HTML issues: those appear because you used the H1 and then jump to an H3. In order to do it correctly you have to make sure to have 1- h1 and then h2, h3 and so on.

Making this one in Flexbox is a little bit tricky if you haven't used before, but bassically you have to put the entire content in a container and make that container flex. This container will have 2 sections: one with the hero text and the little reviews with the stars and the other section has to be the one with the big reviews.

I have this challenge done in my profile with flexbox if you want to check it out for inspiration!

Happy coding!

0

Alexander Lippitsch•120

@LipAlex1Submitted over 2 years ago

Hi guys! I finished the 'QR Code Component'. I found it to be rather straight forward. I incorporated the fonts in a seperate stylesheet and as an additional resource for GDPR reasons.

I'd be happy if you could comment on below points:

In this case I didn't use any semantic HTML, since there was no good use for them imho.
Do you see any possibility to write shorter/more concise/leaner code in my css?

Many thanks in advance! All feedback is greatly welcomed!

QR Code Component

2

Alejandro Hernández Rosa•180

@AlexuvaPosted over 2 years ago

Hi @LipAlex1 !

Overall it's a nice solution! Just a few things about your code:

Make sure you have at least an h1 text in the web, that helps SEO and it's pretty much mandatory.
Use classes instead of id for the elements in the HTML for better reuse of code

CSS tends to be a caotic file with all the elements you have to write in it, if you want to have a cleaner and prettier code, try SaSS! It's easy and makes your CSS look much better

Happy coding!

Marked as helpful

1

Khael•230

@i-am-KhaelSubmitted over 2 years ago

Feedback is always welcome.. in order to improve my coding skill. Thank you for giving feedback.

Interactive Rating Component created with HTML, CSS and JS.

2

Alejandro Hernández Rosa•180

@AlexuvaPosted over 2 years ago

Hey @i-am-Khael ! Nice job! I got a few suggestions to improve your solution:

If you declare the max-width: 1440px in the container that wraps the content of the page instead of putting it on the body, the content will stay in better shape at the largest screens.
The JS is nice, but you could improve it by making that loop check if there is another option already picked, in that way, you could only mark one option before submitting.

Happy coding!!

Marked as helpful

1

Omowaye Gbotemi•70

@gbotescoSubmitted over 2 years ago

i face difficulty with using flexbox to balance my element

Social Proof webpage

1

Alejandro Hernández Rosa•180

@AlexuvaPosted over 2 years ago

Hi @gbotesco!

Nice job!!

About the issues you are facing with responsive:

The entire page should be place in a flex container in order to have a propper position, in that way, you could wrap and manage all the responsive content way easier!
The breakpoint of the responsive desing can be placed before the 375px! If you place it around the 800 it should be fine, cause at 764px it gets stuck!

Happy coding!! :D

PD: Sorry for my English!

Marked as helpful

0

Alejandro Hernández Rosa•180

@AlexuvaSubmitted over 2 years ago