Aldrin Sean Pereira
@AldrinSeanPereiraAll comments
- @Aps-xSubmitted 9 months ago@AldrinSeanPereiraPosted 9 months ago
What beautiful code!
I am amazed by how well it is written and the ideas used!
0 - @Nipaaaa1Submitted 10 months ago
Hello! This is my solution for this Challenge!
This is the first Junior Challenge I take, Tried to use Framer Motion for animation but it didn't work well on mobile navigation, I don't know why :(
If you could give an advice on using Framer Motion, I really appreciate it. But still Any Feedback is Appreciated so if you could look at the code and give a feedback, it really helps. Also, if you haven't review other people code or give a feedback before, feel free to use this as a practice.
Anyway, Happy Coding!
@AldrinSeanPereiraPosted 10 months agoGreat work!!
I think you need to make the logo and nav text smaller
Also the white spacing around the main content needs to be reduced (perhaps reduce margin or padding? )
0 - @Gopinathgopi13Submitted 10 months ago@AldrinSeanPereiraPosted 10 months ago
Hi Gopinath
Read this article from MDN docs to structure your HTML better: link here
Avoid using multiple containers and divs. Keep simple using the above reference.
Also in the CSS for
img
changeobject-fit: fill;
toobject-fit: cover;
0 - @harishfuego33Submitted 10 months ago
review my code please
@AldrinSeanPereiraPosted 10 months agoVery Cool! Great work so far!
problems:
- The cards vertical height is not fixed so when you resize the browser vertically the sizing is different
possible fix:
- in CSS, under
main
change theheight
property fromvh
to arem
value
Marked as helpful1