Pratik Patil• 180
@itspratikpatil2001
Submitted
This was a pretty good challenge for me. Any feedback is greatly appreciated in order for me to improve my skills, thank you in advance🫡.
Alexis Lienard
@Al-lien
All comments
- Alexis Lienard• 150
@Al-lien
Posted
First of all, pardon my English, it’s not my native langage. Here’s my advices :
-
Get rid of not necessary files in your repository (readme template, etc…)
-
use semantic elements (<article>, <section>, etc…) instead of <div> as they clearly defines their contents.
I would recommand this website if you want to know more about semantic elements .
- Finally, since you used relative values for .container, when you reduce the size of your page everything moves and it’s not pretty. Try using an absolute value for your container like px. Then you can change it with media queries when you feel the need to.
Otherwise it’s great work ! See ya !
Marked as helpful
1 -
