I will be glad if you correct my mistakes
Ahmed Alharees
@AhmedAlhareesAll comments
- @developertarikSubmitted over 1 year ago@AhmedAlhareesPosted over 1 year ago
Hi @developertarik. There's problem in solution is that the submit button doesn't function properly. I hope you notice it soon.
0 - @NachohoSubmitted over 1 year ago
This took longer than expected but was fun to make
@AhmedAlhareesPosted over 1 year agoThis is a wonderful solution @Nachoho. But the card is supposed to be centered vertically in the middle of the page, in your solution it's on the top. a solution for this problem is setting the body to 'display: flex' instead of display grid, and apply these changes also: body{ height: 100vh; display: flex; align-items: center; justify-content: center; } and the problem should be fixed. and if you want to keep the attribution div to the buttom, add "flex-direction: column". Good luck.
0 - @jose-jimmySubmitted over 1 year ago
Hey, 👋 everyone
Completed the Base Apparel coming soon page, I usually prefer mobile-first-workflow but since there is a lot happening in the desktop-view started with desktop-first-workflow. This was a pretty good project, to align the image to the right side in the desktop-view I used
float: right
don't know if this is the right approach.Do checkout the code on GitHub and please give it a star ⭐ if you like the solution
Looking for your feedbacks Happy coding! 😃
@AhmedAlhareesPosted over 1 year agoNice solution mate👍🏻. but I don't know if it suppose to do that, but when I write an email and press enter I'm transferred to a blank white page for some reason, I hope you fix that. Other than that, it's nice, keep it up.
Marked as helpful1 - @ferditondeurSubmitted over 1 year ago
Was wondering if I took the right approach with using flexbox instead of grid or a different method altogether.
Right now I used a combination of flexbox and media queries, which I've never used before. Couldn't get it to work organically and to me it feels like I've bruteforced it at the moment, so I would like some feedback on my approach if possible.
At least it seems to work correctly at the specified widths of 1440px and 375px.
@AhmedAlhareesPosted over 1 year agoNice job completing this challenge 👏 couple of notes for you:
- try separating the CSS code into different file, that's the best practice, and It will certainly makes it easier to work with.
- try giving the cards more space on mobile layout, it will make them look better.
- It doesn't matter in small project if it's flex-box or grid, they are both amazing and get the job done, plus if it works it works😅. other than that, good job, and good luck for you.
0 - @MelvinAguilarSubmitted over 1 year ago
Hi there 👋, I’m Melvin and this is my solution for this challenge. 🚀
🛠️ Built With:
- TailwindCSS
- npm - prettier
Any suggestions on how I can improve and reduce unnecessary code are welcome!
Thank you. 😊✌️
- @correlucasSubmitted over 2 years ago
👾 Hello, Frontend Mentor coding community. This is my solution for the 3 Columns Card Component.
Feel free to leave any feedback and help me improve my solution or make the code clean!
- 👾 I added a Custom hover effect on card w/ the Vehicle Types photo on background.
I'll be happy to hear any feedback and advice!
@AhmedAlhareesPosted almost 2 years agoWOW! what an amazing vision for this challenge.
0 - @ashtagmujibSubmitted almost 2 years ago
Any suggestions on how i can improve my work would be very helpful. Thanks.
@AhmedAlhareesPosted almost 2 years agoHonestly, it's beautiful. but i don't know if my screen is too large or something, but there's a white gap on the right, and all the website is pushed to the left. Plus the website doesn't work on smaller screen sizes. I hope you notice that <3.
Marked as helpful0