All comments

• 

  kapowlo• 60

  @kapowlo

  Submitted about 2 months ago

  What are you most proud of, and what would you do differently next time?

  For the width and height of the card, i'm not sure if adding a fixed width and height like I did is a good idea.Maybe using max-width would've been better, not sure.

  What challenges did you encounter, and how did you overcome them?

  Had a hard time creating space around the svg image and similarly border-radius caused me some weird issues.Inside my html file I wrapped the svg img inside of a wrapper and tried setting border-radius on the div wrapper but it didn't work properly.

  What specific areas of your project would you like help with?

  is it better to set a fixed width or use max-width for this particular challenge, or does it not matter that much?after submitting the solution the card is too tall compared to the design and there's a lot of extra space inside of the card(at the bottom), is that happening because i set a fixed height and width on the card?

  

  flexbox and grid blog preview card

  1

  30

  

  Ahmad Ali Aldwairi• 40

  @Ahmadaldwairi

  Posted about 2 months ago

  I like how you played with the body's background. I can see that you have a little bit extra margin at the bottom of the card. Try to play with margin and set it to about 18-20 px and that should feel a bit closer to the original design! Feel free to look at my solution and give any feedback.

  Marked as helpful

  1
• 

  Nathan Akpawu• 100

  @natho19

  Submitted about 2 months ago

  

  QR code component using HTML and CSS

  1

  20

  

  Ahmad Ali Aldwairi• 40

  @Ahmadaldwairi

  Posted about 2 months ago

  Your code is clear and concise. The card component looks good and sizes are just about right. Feel free to look at my solution and give some advice!

  0

  This comment has received 1 replyShow
• 

  Ahmad Ali Aldwairi• 40

  @Ahmadaldwairi

  Submitted about 2 months ago

  What are you most proud of, and what would you do differently next time?

  In this projects, I tried to use only what I have learned so far using basic layout properties (width, height, padding, margin, boarder) without the use of flexbox, positioning, or grid.

  What challenges did you encounter, and how did you overcome them?

  I encountered many challenges including: giving the elements the right width and height, especially that I have not learned the media query yet.

  What specific areas of your project would you like help with?

  Since it is my first project, I still feel that my code is not clean and the approach I took was not the best approach. I know with flexbox, positioning, or grid, it will be easier to layout my elements, but I do need help making basic designs with basic properties so I feel more comfortable with CSS.

  

  QR Code Component using CSS basic Layouts

  3

  40

  

  Ahmad Ali Aldwairi• 40

  @Ahmadaldwairi

  Posted about 2 months ago

  Thank you for the help and advice. I fixed the image and accessibility issues. My sizes are a little bit off but the overall requirements are met. I tried not to use flexbox, grid, or positioning so I can practice centering things using basic properties like margin, padding etc.. For next projects I will start using flexbox because I just learned it.

  Thank you!

  0