Skip to content
Submitted 4 months ago

QR Code Component using CSS basic Layouts

Ahmad Ali Aldwairi•40
@Ahmadaldwairi
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

In this projects, I tried to use only what I have learned so far using basic layout properties (width, height, padding, margin, boarder) without the use of flexbox, positioning, or grid.

What challenges did you encounter, and how did you overcome them?

I encountered many challenges including: giving the elements the right width and height, especially that I have not learned the media query yet.

What specific areas of your project would you like help with?

Since it is my first project, I still feel that my code is not clean and the approach I took was not the best approach. I know with flexbox, positioning, or grid, it will be easier to layout my elements, but I do need help making basic designs with basic properties so I feel more comfortable with CSS.

Community feedback

  • beowulf1958•1,450
    @beowulf1958Posted 4 months ago

    Congratulations on completing the project. Looking good so far.

    The qr-code is not showing because the file path is incorrect. The image is in the root folder, so the correct path is <img src="image-qr-code.png" alt="qr-code">

    Also, rather than positioning the card using margins, you might want to center the card on the page. One way to do this is with flexbox. Try this:

    body {
  display: flex;
  flex-direction: column;
  align items: center;
  justify-content: center;
 min-height: 100vh;
}

    That should place the card in the middle. Hope this helps.

    Marked as helpful
    1
  • Nathan Akpawu•100
    @natho19Posted 4 months ago

    This seems correct to me. One point I noticed is that the box-shadow is missing on the card. Have a good day !

    Marked as helpful
    0
  • Ahmad Ali Aldwairi•40
    @AhmadaldwairiPosted 4 months ago

    Thank you for the help and advice. I fixed the image and accessibility issues. My sizes are a little bit off but the overall requirements are met. I tried not to use flexbox, grid, or positioning so I can practice centering things using basic properties like margin, padding etc.. For next projects I will start using flexbox because I just learned it.

    Thank you!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord