All comments

• 

  Hisham Abdelalem•150

  @HeshamAbdelalemSubmitted over 1 year ago

  

  html5 , css3, grid , flexbox

  2

  71
  

  Afnan Malik•180

  @AfnanmkPosted over 1 year ago

  Hi, Congratulations on completing the challenge. I appreciate your work. You have done a great job!

  I have a suggestion for you to improve the visual design. On larger screen sizes(from 2000px) the design does not look very good. You can improve that by adding main {max-width:1440px}. So that the container width will not stretch as the screen size gets bigger.

  Marked as helpful

  1
• 

  impiia•400

  @impiiaSubmitted over 1 year ago

  

  Calculator app in pure HTML, CSS, and JavaScript

  1

  50
  

  Afnan Malik•180

  @AfnanmkPosted over 1 year ago

  Congratulations on completing the challenge! I am sure you have put a lot of effort into it. Your code is well-structured and readable. The layout also looks good on different screen sizes. I have a few suggestions for you to improve your project further.

  • You can center the calculator container on the screen by applying the below code snippet -

  body {
  width: 100vw;
  display: grid;
  min-height: 100vh;
  place-items: center;
  }
  

  • The height of your result display screen increases when the numbers are bigger. It does not look good and messes up the layout. You can avoid that by adding overflow:scroll and removing height:auto in .calc-display . Also, remove overflow-wrap from .result-field

  Marked as helpful

  0

  This comment has received 2 repliesShow
• 

  P

  Joshua Abraham•230

  @joshbrahamSubmitted over 1 year ago

  All feedback appreciated :)

  

  Responsive Calculator App using CSS Flexbox & Grid

  1

  40
  

  Afnan Malik•180

  @AfnanmkPosted over 1 year ago

  Hi Joshua, You have done a great job! There is a little thing that needs to be fixed. When I toggle the theme switcher, It moves from 3 to 1 directly. I could not move from 3 to 2. I hope you understand.

  0