Skip to content
OverviewSolutions
3
Comments
2
Adejoh Ojochenemi Sunday
@AdejohOS

All comments

  • Vaishnavi•10
    @Vaishu03Submitted almost 2 years ago

    Did you find any problem in viewing the QR code in mobile and desktop views?? Any suggestions to improve project code?

    QR Code using html and css

    2
    Adejoh Ojochenemi Sunday•80
    @AdejohOSPosted almost 2 years ago

    This is great Vaishnavi, A little tweak here and there can still be done.

    The link to your source code is broken, so i can't see your codes.

    But i think you can

    -Set img{ width:100%; display:block;} this makes the image responsive and fit the size of it's container.

    -Having fixed height and width for .container will cause text to overflow when they don't get enough room, so you need to know this.

    -Happy Coding!!!

    Marked as helpful
    0
  • Adejoh Ojochenemi Sunday•80
    @AdejohOSPosted almost 2 years ago

    This is a good one, but i think the following will also be cool. --Ensure you have a reset *{margin:0; padding:0; box-sizing:border-box} then add background-color to .main and eliminate .contbody, takeout flex, height from .screen and add padding eg 1rem. Eliminate .pbox, eliminate .pic, you can takeout height from img so image don't get distorted, takeout flex, height from .conttext so your text can flow eaisly and add text-align:center and a little padding. Eliminate .text. Replace .abo with a heading tag eg h1, set padding-bottom and font-size..... One Love!!!

    Marked as helpful
    0