Skip to content
OverviewSolutions
6
Comments
3

Eric Akoten

@AceKahuna175 points

An upcoming software Guru

I’m currently learning...

I'm currently learning Javascript

Latest solutions

Latest comments

  • Eric Akoten•175
    @AceKahunaPosted over 4 years ago

    Hello there Uzumakiabba, hope you doing fine. You have done good and the code looks fine and congrats on finishing that challenge. There are a few things that you need to put into consideration. As you can see, you didn't add the background image instead of the plain hair. background-image: url('/intro-component-with-signup-form-master/images/bg-intro-desktop.png'); As you can see you have used the wrong path to the image instead use background-image: url('/images/bg-intro-desktop.png'); You can tweak the widths and padding to match the design. Once again Congrats

    0
  • Eric Akoten•175
    @AceKahunaPosted over 4 years ago

    Hey there Victor, the code looking good and good job on your first challenge. Just like in the report, use the forward-slash instead of the backslash to avoid such issues <link rel="icon" type="image/png" sizes="32x32" href="./images/favicon-32x32.png"> The responsiveness is smooth needs just a lit adjustment on the padding and width so that it can match the design. Congrats again, looking forward to more of your projects submissions.

    0
  • Eric Akoten•175
    @AceKahunaPosted over 4 years ago

    Hey there Ben, checked out your code and it looks fine. No need to worry about nesting since it helps out define the properties much efficiently and helps avoid making mistakes while calling a certain class or an element in vanilla CSS. On the media queries, you can create a @Mixin instead of having to write the code manually.

    @mixin tab-land{
  @media screen and (min-width: 992px) {
    @content;
  }
}

    Set a min-width and max-width for the elements to avoid it squishing in the mobile view

    1