@jay-kambleSubmitted over 2 years ago
Hi guys! Please comment on any thing (advice and fixes) if you see anything . Any feedback is welcome and much appreciated.
Thank you :)
Abby Nyakara
@AbbyNyakaraAll comments
- @AbbyNyakaraPosted over 2 years ago
The solution is nicely executed. However, just a few things:
- If you have a css style sheet, you could just transfer all the styling there. I see you left the attribution section in the html file.
Marked as helpful0 - @EmmanuelOludareSubmitted almost 3 years ago
Please check out this and my other projects and rate my coding
@AbbyNyakaraPosted almost 3 years agoHi Michael, I see you did all the styling in the html file. It is not good practice. its better to create a css file separately that will take all the styling.
- Also, you did not do the proper display on desktop view. You can have a div that holds the left-div(the contents) and right-div(image). You can then set the display to flex and flex-direction: column(mobile view), and change the flex-direction to row-reverse in desktop view.
1 - @chrischakritSubmitted almost 3 years ago
Please have a look my solution. I would love to see any feedback/ comments. Thanks you.
@AbbyNyakaraPosted almost 3 years agoHi Chris. This is pretty good actually. I like that you centered the page nicely and avoided unnecessary scroll bars!
Marked as helpful1 - @mohmd2004Submitted almost 3 years ago
Hello Everyone, Here is my solution for this challenge tell me about which thing I do it badly and which I can do better that will help me a lot
@AbbyNyakaraPosted almost 3 years agoHi. This is actually nicely done. Maybe the only thing you need to do is to remove the default email verification that automatically appears when you have input type as email. I haven't found the best solution for that yet, but what i did was to change the input type to text instead of email. That will ignore the automatic default verification.
Marked as helpful0 - @EdwardJrScSubmitted almost 3 years ago
Can someone help me with something, I couldn't make the active states, I had problems with the position of the elements :(
@AbbyNyakaraPosted almost 3 years agoHi Edward, it seems like your live site did not load properly. Maybe you might need to re-upload that first then it will be easier to give feedback.
0 - @billbahrSubmitted almost 3 years ago
I feel like to be production ready this solution would require some cleanup and a bunch more data validation and error checking. Do people usually spend a lot of time on that kind of thing in these challenges?
@AbbyNyakaraPosted almost 3 years agoWell, I have seen a lot of people customize these solutions even using animations. You should really just feel free to do so and make the challenge your own.
Marked as helpful0 - @hyunnies95Submitted almost 3 years ago
Just trying to improve accuracy
- @valli450Submitted almost 3 years ago
Any suggestions on how I can improve are welcome!
@AbbyNyakaraPosted almost 3 years agoThere are a few issues that you might need to look into.
- The page doesnt display properly in desktop view.
- The javascript is nicely done, but there seems to be an error on the email section. When you enter a valid email, there is still an error message.
But overall, good job.
0 - @Gab-FerreiraSubmitted almost 3 years ago
If you have any suggestions please tell me, I have to improve.
@AbbyNyakaraPosted almost 3 years agoYou could center it completely so you can avoid scroll bars. I think that would be the icing on the cake. Also, on the link to your github(attribution), you could add the target="_blank" attribute so it opens in a different tab. Otherwise. Good work!.
1 - @AchrefFastSubmitted almost 3 years ago
Hi everyone,
I would really appreciate any feedback or suggestion you can offer me to improve my solution. if the solution is all right, please let me know, that motivates me.
Thanks 🙏🙏😊😊.
- @Auto-YahwinSubmitted almost 3 years ago
I can now overlay my background image with colors and effects, thanks to the community for the response.
@AbbyNyakaraPosted almost 3 years agouse the css filter property to add the opacity. This was how i did mine
img{ filter: opacity(35%) drop-shadow(0 0 hsl(277, 64%, 61%)); }
Marked as helpful1
