Skip to content
OverviewSolutions
5
Comments
9
Ali khaled
@ALI-KHALED-13

All comments

  • Namrata Sinha•530
    @nmrtsnhSubmitted about 1 year ago

    Hello everyone,

    I am Namrata and this is my solution for this challenge.

    If you have any suggestions to improve my code, please feel free to share!

    Thank you 🙏

    Article preview component

    2
    Ali khaled•170
    @ALI-KHALED-13Posted about 1 year ago

    well done, I liked the photo animation upon hover

    0
  • kimanthigregory•100
    @kimanthigregorySubmitted about 1 year ago

    hello my fellow developers. I am presenting to you my Article preview solution. This project has helped me delve into the world of CSS animation which I had previously ignored but through this project I can't wait to do another project which involves the same. I have also noticed some improvement on my JavaScript skills since I didn't google for help but that doesn't mean I perfect 👌 I still need to take on more projects and work on writing clean code. Please take a look at my code on GitHub and give me feedback on what I can do better. happy coding everyone.

    Article preview component

    1
    Ali khaled•170
    @ALI-KHALED-13Posted about 1 year ago

    Well done on the animation bit, I liked it :) Try to close the share pop up when the user clicks anywhere outside it. A small JS challenge ;)

    0
  • Ali khaled•170
    @ALI-KHALED-13Posted about 1 year ago

    It's beautiful, I felt repeating the page animation for navigation of planets/crews is a bit too repetitive, and it takes too long 😅

    other than that well done

    Marked as helpful
    0
  • Mehdi•990
    @siavhnzSubmitted over 1 year ago

    Hello Dear Community

    In this challenge I used React Router And Figma for the first time of challenges, and I need to solve more challenges like this. I learned a little about React Router and I really enjoyed working with Figma, that's amazing

    Thanks for viewing my solution, Any recommendation is appreciated

    Space Tourism Website

    1
    Ali khaled•170
    @ALI-KHALED-13Posted over 1 year ago

    Loved it, well done And I liked how you integrated sliding with swipes. so does my solution btw

    1
  • Ali khaled•170
    @ALI-KHALED-13Posted over 1 year ago

    I like your animation to the website a lot, well done.

    One comment is the background image moving as you scroll any page (using phone) Not sure how you can fix it coding wise since I'm not familiar with SCSS

    Good work :)

    0
  • Rino•340
    @Rhinozer0sSubmitted over 1 year ago

    Hey guys,

    can someone help me with the red label of the input field that should appear if the input is incorrect?

    It was also difficult for me to match the right font-size. There was no font-size specified.

    Otherwise all suggestions for improvement are welcome.

    Thanks🤝

    Responsive Website using SCSS

    1
    Ali khaled•170
    @ALI-KHALED-13Posted over 1 year ago

    Beautiful ! The best solution I've seen after mine ;) Matching the design very closely.

    One advice is to preventDefault() upon form submission; the current behaviour is that the webpage reloads when you click on submit button. You can fix that by attaching an "onsubmit" function and call preventDefault() on the event paramter

    0
  • Ali khaled•170
    @ALI-KHALED-13Posted over 1 year ago

    well done, mobile and desktop views are perfect. tablet mode needs some fixing though, you can emulate tablet view that from Edge/chrome dev tools

    0
  • Ali khaled•170
    @ALI-KHALED-13Posted over 1 year ago

    well done overall. one possible enhancement is to apply the alternation in background-color as in the design. consider using the nth-child rule o your "mockup" class

    .mockup:nth-child(even) {}

    also the placement of the .intro div inside the header seemed strange to me

    0
  • Ali khaled•170
    @ALI-KHALED-13Posted over 1 year ago

    The layout looks great, well done on matching the design ! I have one comment though: "mark all as read" button should turn all notifs to read state. you would need some javascript to do that :)

    /* some bla bla text so I can post the comment dfdlgnhldgh nkfmnhkl fkgn lfn lfngl nfln jnfiln flgn lfn lfn fngn flgn flng lfn fln lfn lfnl nfl nlfn lfn lfgnl */

    Marked as helpful
    0