space-tourism-website-main
Design comparison
Solution retrospective
All feedback is Welcome. Thank You.
Community feedback
- @vladmeePosted over 1 year ago
Good work! Your HTML structure is well-thought-out, and the CSS adheres to best practices. That said, I do have a few observations:
1.Some elements, like the Explore (large) button, don't resize across different devices. It could be beneficial to use media queries or, even better, viewport units (vw) to manage element sizing.
2.@ALI-KHALED-13 has already pointed this out, but the tablet view doesn't quite match the design instructions.
3.The padding around the content appears a bit thin. It might be worth revisiting.
On a positive note, I'm a fan of how you've started your CSS with variables, resets, and utility classes. Your naming conventions are clear and consistent, and the smart use of rem and clamp across all elements is commendable. The use of media queries in em is super impressive.
Overall, it's a solid effort. I'd suggest spending a bit more time refining the responsiveness to polish it up. Keep up the good work!
0@khophisnowPosted over 1 year ago@vladmee thanks for your feedback will see to that as soon as possible .
1 - @ALI-KHALED-13Posted over 1 year ago
well done, mobile and desktop views are perfect. tablet mode needs some fixing though, you can emulate tablet view that from Edge/chrome dev tools
0@khophisnowPosted over 1 year ago@ALI-KHALED-13 well noted. Thanks for your feedback
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord