Skip to content
OverviewSolutions
2
Comments
3
Anietie Brownson
@AJBrownson

All comments

  • Anietie Brownson•80
    @AJBrownsonPosted over 2 years ago

    Nice one Patil It looks good and responsive, however you omitted the lightbox functionality And I don't know if it just me but I can't seem to find your React files(is it minified or something?) You might want to take a look at the accessibility issues coming up in the report above

    Kudos

    Marked as helpful
    0
  • Anthony Waweru Njeri•180
    @anthonynwaweruSubmitted almost 3 years ago

    Hello, if you are reading this, kindly share a few things that I could do to improve this project, thank you.

    HTML, CSS & JS

    3
    Anietie Brownson•80
    @AJBrownsonPosted almost 3 years ago

    You did pretty good @Anthonypmarcel

    The guy above has pretty much said everything but some things remain for you to do to clear all those accessibility issues.

    Don't leave your href tag blank. You have to put in some text e.g. in the case of the Collections link, you can put in something like www.e-commerce.com/collections. Do this for all your links.

    It's very important for your webpage to have a H1 tag. Change your H6 tag to H1 and you can style it to look smaller if you want but just make it a H1 tag.

    I hope that this helps to clear all those accessibility issues.

    Good Luck.

    Marked as helpful
    1
  • Anietie Brownson•80
    @AJBrownsonPosted almost 3 years ago

    Good work @GJCIII but you still have lots of work to do to improve your code

    First of all, wrap your entire code in a main tag and then put your Equilibrium #3429 inside a H1 tag and then you style it using the hover property and setting the color to cyan.

    Same goes for the Creator's name (Jules Wyvern), use the hover effect also for this.

    I noticed you didn't implement the overlay effect on your image but that's okay. Just check other solutions and see the various ways others are solving that problem.

    Also here is a tool that someone just recommended to me: https://www.deque.com/axe/devtools/

    It really helps to identify accessibility issues that may be wrong in your code.

    I hope this feedback helps. Good luck

    Marked as helpful
    0