The ratio of the main image is a bit off in full width, while it's ok in 1440px and I have no real clue on how to handle that correctly and that's the main issue, also kinda messed up by using vh for some sizes, which messes up everything once a too tall screen is used, will keep it in mind for next project
Juan Zapien
@1ZapienAll comments
- @DardouSubmitted about 3 years ago@1ZapienPosted about 3 years ago
Hello @Dardou for the hero section you just have to play with the sizing. Right now the section is to short so in order to fit the image it stretches it horizontally. Maybe try
min-height: 35rem;
0 - @K-MannnnSubmitted about 3 years ago
Hello Everyone,
Tried to make this using semantic Html for the first time and hoping it'll be more accessible to screen reader users. But you feedback/comments will be highly appreciated to help me improve further. I couldn't get the custom email validation error message right using just html and CSS, guess bit Javascript was needed for that, however I stuck with Html and Css as per the challenge.
@1ZapienPosted about 3 years agoHello Kiran, since you are working on accessibility you should add aria labels to your media links.
For example: <a href="" aria-label="Twitter"><i class="fab fa-twitter"></i></a>
This will add a label/context to your link which will be used by screen readers.
You can look into Aria here. Just use them when there are no semantic tags in HTML though.
0