Design comparison
Solution retrospective
at the end my clean code turn out so nasty(desktop) so i left if like this
Community feedback
- @skyv26Posted almost 3 years ago
Hi! Arash, good attempt, you tried your best. You have to solve below issues.
-
Your design or layout is smaller, it should cover your laptop viewport, I mean it takes full width and height and must be responsive, so that it would not overflow.
-
As I tried to enter email, on wrong email, it gave me error and ofcourse it is absolutely fine but as I entered the correct format email then it also gave me error. Reason is you have hard coded the logic, if use add 'gmail.com' in the end after @ symbol then it will be validate otherwise results error. It is not a good way, not everyone use gmail, someone might be using yahoo, yandex, outlook emails. So Fix it.
Overall in my opinion you have implemented majority width media query for responsiveness. I hope you understand above issue and soon will all of them (above mentioned)
Best Of Luck
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord