Hello again @nvalline :)
Here are the points I liked compared to my own approach:
• Use of crypto.getRandomValues: This is a good practice to enhance the security of the password generation process.
• Validation of options: The logic for validating options using FormData is interesting to ensure that at least one option is selected before generating the password. This could be useful if I want to implement more rigorous validation in my own code.
• Visual feedback on the slider: The visual feedback on the slider’s progression is a nice enhancement for the user interface and could be a good addition to my project.
The design is faithful to the original mockup, and I'm always impressed by how you're able to achieve an almost pixel-perfect integration.
I noticed an issue in the application where, if you adjust the slider to set a maximum number of characters but don’t check any options, the output displays undefinedundefinedundefinedundefined. Perhaps you could add a validation step in the logic to handle this case.
Congratulations on the code and the project! Keep up the great work!
Marked as helpful
0
