Hi Aleksei,
Really liking your solution, the semantic html looks great, and layout and functionality work great on mobile and desktop.
I'm no expert, but I do have a couple of suggestions:
~ The popover opacity transition works great on entrance, but when data-hidden="true"
, the "visibility: hidden"
immediately removes the popover from the layout, overriding the opacity transition, causing it to snap out of display. Here's a link to a yt video about transition to and from display: none which I recently came across, it may be useful for you! The title of the video is the link text, in case you don't want to follow the link :)
We can now transition to and from display: none - Kevin Powell
~ This is purely aesthetic, but putting -webkit-tap-highlight-color: transparent;
on buttons and hyperlinks removes the blue box highlight which appears on mobile when tapped.
Nice work mate, hope this is somewhat helpful!
Marked as helpful
@alekseibodeev
Posted
Thanks for your feedback @j-hogben
I've just tried out transition from display: none
and it's awesome. Can't wait for better browser support