@skyv26
Posted
Hi! Joska, Good work but rather than to tell you design issue I would love to tell you your react work.
-
DRY It is the first concept that is really important to keep in mind it is acronym for DON'T REPEAT YOURSELF. As I saw your respository, you have added your content twice at two different place and named them desktop.js and mobile.js, It is absolutely not a good way of working on ReactJS. I think it need to fix.
-
You haven't implemented any media query and your design still responsive because of GRID layout. But what you have done as I told you in above issue is not a right way. you can do one thing either make it responsive or adaptive and now it is upto you what to choose. Search on google about adaptive and responsive. Your design is adaptive but it violate DRY principle too.
I hope you understand and if you any doubt feel free to comment by mentioning me.
GOOD LUCK
Marked as helpful
