Skip to content
Submitted almost 3 years ago

Using React.js

Joska•500
@LowkeyCoyote
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Single price grid component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello ! This is my first project using React, i'm not sure if the organisation is correct and i don't know if this is the best way of using media queries. Any feedback or commentary will be appreciated !

Community feedback

  • Aakash Verma•6,710
    @skyv26Posted almost 3 years ago

    Hi! Joska, Good work but rather than to tell you design issue I would love to tell you your react work.

    1. DRY It is the first concept that is really important to keep in mind it is acronym for DON'T REPEAT YOURSELF. As I saw your respository, you have added your content twice at two different place and named them desktop.js and mobile.js, It is absolutely not a good way of working on ReactJS. I think it need to fix.

    2. You haven't implemented any media query and your design still responsive because of GRID layout. But what you have done as I told you in above issue is not a right way. you can do one thing either make it responsive or adaptive and now it is upto you what to choose. Search on google about adaptive and responsive. Your design is adaptive but it violate DRY principle too.

    I hope you understand and if you any doubt feel free to comment by mentioning me.

    GOOD LUCK

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord