using grid and flexbox

Community feedback

• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted about 4 years ago

  Hi Esra, great job with this challenge, the desktop version looks really close to the design. Would've liked to see a more responsive site, currently there are horizontal scrollbars as you resize the screen. Also, the .container div needs horizontal centering. If your screen width is more than 1440px, the component is stuck on the left side of the screen. Hover states on the button and social links would be a nice addition as well. Hope this helps :-)

  0

  ---

  

  esraagamal•600

  @EsraaGamal-22Posted about 4 years ago

  @emestabillo Thanks for your feedback, can you see my code after edit?

  0

  

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted about 4 years ago

  @EsraaGamal-22 Hi Esra, for your hover states, try making them smoother as explained here. More importantly, for your next project, try to be aware of overflow in different screen widths to avoid the scrollbars from appearing.

  0

  

  esraagamal•600

  @EsraaGamal-22Posted about 4 years ago

  @emestabillo ok .done first note, but I can't understand what do you mean by avoiding the scrollbars from appearing, can you explain this note in my project?

  0

  

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted about 4 years ago

  @EsraaGamal-22 The user has to scroll to the right to view the entire design, instead of the site fitting in the viewport it is in. It's quite apparent on mobile view you can check it from there. It's a common overflow problem where one or more of your elements are bigger than the current screen width.

  0

  

  esraagamal•600

  @EsraaGamal-22Posted about 4 years ago

  @emestabillo my reply on slack, check messages for a clear explanation

  0