Using css & js

Community feedback

• 

  Imran Khan•370

  @astr0n0merPosted almost 2 years ago

  Hello @Leracius, nice work on your solution.

  Here are some areas that you might want to improve upon

  HTML:

  • While it would make sense wrapping the component in a <section> in a bigger project, but for this challenge, you can replace the <section> tag with <main> tag

  CSS:

  • Rather than using width directly, you can set #container's width:min(95%, 570px);. This way, it will always be 95% of the parent's width, and will take 570px as the maximum width.
  • In general, try to avoid giving width to block level elements
  • This course by Kevin Powell would be helpful in clearing out some responsive layout problems

  Well done, it's a great solution 😁😀

  Marked as helpful

  0