Imran Khan

Latest comments

• 

  Yeison Hernandez•10

  @Yeison2017Submitted about 2 years ago

  

  QR code component

  2

  10
  

  Imran Khan•370

  @astr0n0merPosted about 2 years ago

  Hi @Yeison2017, you're off to a great start

  Some corrections as you're using BEM

  • The <div> with class="cardQR__content" is a block and should have its own name, maybe "content"
  • And then the children will be "content__title" and "content__info"

  You can consider these resources for expanding your knowledge on BEM:

  • 🎥 Why I use the BEM naming convention for my CSS
  • 🗒️ BEM 101 on css-tricks

  Good luck. Happy coding 😁😀

  Marked as helpful

  0
• 

  Babatunde•20

  @n-uzumakiSubmitted about 2 years ago

  

  qr-code challenge attempt

  2

  30
  

  Imran Khan•370

  @astr0n0merPosted about 2 years ago

  Hey @n-uzumaki, you're off to a great start

  HTML:

  • You can replace the <h5> with an <h1> for better accessibility
  • Do the styling in CSS

  CSS:

  • You can explore CSS naming conventions, namely BEM. This will make your code more readable for yourself and for others. Don't get me wrong, your code is readable even now, but BEM or any other convention for that matter, will definitely be helpful

  Happy coding. Good luck 😁😀

  Marked as helpful

  0
• 

  Hồ Đắc Minh Quân•110

  @tetinhxuanSubmitted about 2 years ago

  

  Advice generator app use basic fetch API

  1

  40
  

  Imran Khan•370

  @astr0n0merPosted about 2 years ago

  Hi @tetinhxuan, that's a fantastic solution

  Just a small suggestion, you can set the witdh of your <main> element as width: min(90%, 600px);. Reference to min()

  This way, it will get you rid of the media query and will provide more responsiveness to your page

  Happy coding 😁😀

  Marked as helpful

  0
• 

  Axel Quintana•120

  @LeraciusSubmitted about 2 years ago

  

  Using css & js

  1

  30
  

  Imran Khan•370

  @astr0n0merPosted about 2 years ago

  Hello @Leracius, nice work on your solution.

  Here are some areas that you might want to improve upon

  HTML:

  • While it would make sense wrapping the component in a <section> in a bigger project, but for this challenge, you can replace the <section> tag with <main> tag

  CSS:

  • Rather than using width directly, you can set #container's width:min(95%, 570px);. This way, it will always be 95% of the parent's width, and will take 570px as the maximum width.
  • In general, try to avoid giving width to block level elements
  • This course by Kevin Powell would be helpful in clearing out some responsive layout problems

  Well done, it's a great solution 😁😀

  Marked as helpful

  0