Used React, React-Router, React CSS modules

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Achref, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • instead of using multiple p for the details of country you can use ul element
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of flag images
  • instead of using px use relative units of measurement like rem -> read here
  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • I would also add a query reset button, I find it very convenient

  Overall you did well 😁 Hope this help!

  Marked as helpful

  1

  ---

  

  Achref KS•530

  @AchrefFastPosted over 2 years ago

  @denielden Hi Deniel, thank you so much for the tips. I'll make sure to adjust my solution by using them.

  Many thanks😊😊 .

  1