Used CSS and some flex method

Community feedback

• 

  Hikmah•1,070

  @HikmahxPosted about 1 year ago

  Hi Lipe 👋! I checked your solution and you did great work on this project! I have a few suggestions for you:

  • You should add a padding of 1rem to the body of your application:

  body {
      padding: 1rem;
  }
  

  This is so that on smaller screen sizes, the QR code container can have some spacing around it.

  Hope this helps

  Marked as helpful

  0

  ---

  

  Lipe•20

  @LipeCatPosted about 1 year ago

  Hello @Hikmahx ! I really appreciate your advice, thank you very much. I will add it.

  0
• 

  Bryan Li•3,530

  @Zy8712Posted about 1 year ago

  Your site looks pretty good. Main things I'd say you should add/modify is:

  • using a <main> tag to wrap around your content, this is for accessibility purposes
  • set body height to height: 100vh; this will keep your container perfectly centered
  • use a <h1> header instead of a <h2> header as headers are meant to be used in order from h1 to h6 with skips. Each header has a default starting font size that can be changed using the font-size property in css.

  Hope you find this useful 👍

  Marked as helpful

  0

  ---

  

  Lipe•20

  @LipeCatPosted about 1 year ago

  Hi @Zy8712 ! I really appreciate your advices, thank you very much.

  I forgot that detail. Do I replace the <main> tag with the containing <div> tag or add it as the parent tag of all content?

  Once again, thanks for your feedback and time.

  0