URL Shortening API landing page using react

Community feedback

• 

  P

  Marge C.•440

  @msunjiPosted over 2 years ago

  Heya! Great job solving this challenge 👍

  A couple of suggestions, but I'll try to keep this short:

  • If I'm being honest, your CSS is a little hard to read through 😅. I would suggest using something like the BEM Method to organise and structure your code.
  • You may want to remove the default styling for ol, ul elements. Set their margin and padding to 0. After this, you can remove the left margin from your h6 elements. This should help line up the list elements with the h6 headings.
  • You have some redundant/repeated code that you may want to simplify or clean up. For instance, you have two declaration blocks for your a element. For the aside element, you can remove height: 25%, and set top and bottom padding instead. Once that's sorted, consider removing the started class from the button in your aside element.
  • For responsive CSS best practices, you can try using a mobile-first workflow. Kevin Powell does a lot of videos about responsive CSS, so you may want to start there.

  Hope this helped! Best of luck with future challenges!

  Marked as helpful

  1

  ---

  

  Sameer•60

  @msi117Posted over 2 years ago

  @msunji Thanks for your honest feedback. I really appreciate. This tutorial by Kevin Powell looks great. Thanks again.

  0