To solve this problem, I used only html and css, I'm open to criticism

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello Joseildo, Congratulations on completing this challenge!

  Your solution its almost done and I’ve some tips to help you to improve it:

  Using <picture> you’ve more control over the elements and its better than using the product image as <img> or background-image. Look that for SEO and search engine reasons it isn't a better practice to import this product image with CSS since this will make it harder to the image. You can manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device (phone / computer) Here’s a guide about how to use picture: https://www.w3schools.com/tags/tag_picture.asp

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0
• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  Hi @Josnjs,

  Nice job on completing the challenge

  Just a few suggestions, instead of using padding to try and center the card you can use flexbox, replace you body rule with the following.

  body {
      background-color: hsl(30, 38%, 92%);
      margin: 0;
      display: flex;
      flex-direction: column;
      align-items: center;
      justify-content: center;
      min-height: 100vh;
  }
  

  and set the footer margin-bottom: 0.

  Also just check the report above there are a few issues they are usually easily to fix.

  Hope this is helpful. Let me know if you have any other questions.

  Marked as helpful

  0
• 

  Alan Lopez Reyna•300

  @AlanLopReyPosted about 2 years ago

  Good first attempt I recommend you to start the design with the mobile first methodology, and set the image in the CSS document with the background-image property and the url() function in you're case it will be something like background-image: url(images/image-product-mobile.jpg); if you don't see the image appear you need to give it a width I hope I've been helpful ;) don't give up

  Marked as helpful

  0
• 

  Joseildo•90

  @JosnjsPosted about 2 years ago

  Thank's friends, I will follow yours recommendations.

  0