Design comparison
Community feedback
- @MavreonPosted over 2 years ago
Hey Julio! Congratulations on completing this challenge. For the design you nailed it for the most part, but the mobile appeal is a bit off, I can see your title overflowing into the unknown of my web browser... Incase you need a few pointers on how to address that, I'd be happy to share my repo link so you could use my code as reference. Also I think you might have rounded up the tip amount maybe because you observed the calculation yielded a value with a very long decimal point. You can address that using the toFixed() function, Read more about it
Here's a few pointers to help with your HTML validation issues and accessibility issues:
In order to resolve some of your accessibility issues, you might wanna use landmarks in your html code, these help browsers easily navigate your code. So you might consider wrapping your divs in landmarks like
<main>
or<header>
or<footer>
you need to do this according to how your page is structured. Incase you want to know more about landmarks, follow this link. You might want to add labels to your form input elements, this enables the browser to properly identify the input elements within your form and it's also beneficial to people with using screen readers.Happy coding and keep up the good work👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord